Explicit header definitions for Open XL warnings

Open XL 2.1 on z/OS reports some of the implicit declarations
as errors, and requires these to be explicitly defined. Most of
the underlying changes are to address this concern and some other
fixes pertaining to compilation errors.

zos.cmake now uses _XOPEN_SOURCE=600, which implies/includes already
namespaces from _POSIX_SOURCE, _XOPEN_SOURCE_THREADED, _ISOC99_SOURCE.
See feature test macros: https://www.ibm.com/docs/en/zos/3.1.0?topic=files-feature-test-macros
timer.h - unneeded conditional removed
Array.hpp - uninitialized variable addressed

Signed-off-by: Gaurav Chaudhari <[email protected]>

Author: Deigue

cmake/modules/platform/os/zos.cmake

@@ -21,17 +21,21 @@
 
 list(APPEND OMR_PLATFORM_DEFINITIONS
 	-D_ALL_SOURCE
+	-DJ9ZOS390
+	-DLONGLONG
 	-D_OPEN_THREADS=3
-	-D_POSIX_SOURCE
-	-D_XOPEN_SOURCE_EXTENDED
-	-D_ISOC99_SOURCE
 	-D__STDC_LIMIT_MACROS
-	-DLONGLONG
-	-DJ9ZOS390
 	-DSUPPORTS_THREAD_LOCAL
+	-D_XOPEN_SOURCE=600
 	-DZOS
 )
 
+if(OMR_ENV_DATA64)
+	list(APPEND OMR_PLATFORM_DEFINITIONS
+		-DJ9ZOS39064
+	)
+endif()
+
 # CMake ignores any include directories which appear in IMPLICIT_INCLUDE_DIRECTORIES.
 # This causes an issue with a2e since we need to re-specify them after clearing default search path.
 list(REMOVE_ITEM CMAKE_C_IMPLICIT_INCLUDE_DIRECTORIES /usr/include)

cmake/modules/platform/toolcfg/xlc.cmake

@@ -166,10 +166,6 @@ elseif(OMR_OS_ZOS)
 	)
 
 	if(OMR_ENV_DATA64)
-		list(APPEND OMR_PLATFORM_DEFINITIONS
-			-DJ9ZOS39064
-		)
-
 		list(APPEND OMR_PLATFORM_COMPILE_OPTIONS
 			-Wc,lp64
 			"\"-Wa,SYSPARM(BIT64)\""

compiler/cs2/timer.h

@@ -81,7 +81,7 @@ class AIXTimer {
 };
 
 typedef AIXTimer PlatformTimer;
-#elif defined(LINUX) || defined(OSX) || (defined (__MVS__) && defined (_XOPEN_SOURCE_EXTENDED))
+#elif defined(LINUX) || defined(OSX) || defined(__MVS__)
 /**
  * \brief Linux-specific timer class.
  *

compiler/infra/Array.hpp

@@ -227,7 +227,7 @@ template<class T> class TR_Array
       uint32_t prevSize = _nextIndex * sizeof(T);
       uint32_t newSize = size * sizeof(T);
 
-      char * tmpArray;
+      char * tmpArray = NULL;
       if (_trMemory)
          tmpArray = (char*)_trMemory->allocateMemory(newSize, _allocationKind, TR_MemoryBase::Array);
       else if (_trPersistentMemory)

include_core/unix/thrdsup.h

@@ -89,6 +89,12 @@ int linux_pthread_cond_timedwait(pthread_cond_t *cond, pthread_mutex_t *mutex, c
 intptr_t init_thread_library(void);
 intptr_t set_pthread_priority(pthread_t handle, omrthread_prio_t j9ThreadPriority);
 intptr_t set_pthread_name(pthread_t self, pthread_t thread, const char *name);
+intptr_t sem_init_zos(j9sem_t s, int pShared, int initValue);
+intptr_t sem_destroy_zos(j9sem_t s);
+intptr_t sem_getvalue_zos(j9sem_t s);
+intptr_t sem_trywait_zos(j9sem_t s);
+intptr_t sem_wait_zos(j9sem_t s);
+intptr_t sem_post_zos(j9sem_t s);
 
 extern struct J9ThreadLibrary default_library;
 

port/zos390/omrcel4ro31.h

@@ -124,7 +124,7 @@ omr_cel4ro31_call(OMR_CEL4RO31_infoBlock *infoBlock);
  * @return whether CEL4RO31 runtime support is available.
  */
 BOOLEAN
-omr_cel4ro31_isSupported(void);
+omr_cel4ro31_is_supported(void);
 
 /**
  * A helper routine to return an error message associated with the CEL4RO31 return code.

port/zos390/omrgetjobid.c

@@ -23,6 +23,7 @@
 #include <stdlib.h>
 #include "omrport.h"
 #include "omrgetjobid.h"
+#include "omrportpriv.h"
 
 #define JOBID_STRING_LENGTH 9
 

port/zos390/omrgetjobname.c

@@ -48,6 +48,7 @@ void
 omrget_jobname(struct OMRPortLibrary *portLibrary, char *jobname, uintptr_t length)
 {
 	char *tmp_jobname = (char *)__malloc31(J9_MAX_JOBNAME);
+	extern void _JOBNAME(char *); /* defined in omrjobname.s */
 
 	if (NULL != tmp_jobname) {
 		char *ascname = NULL;

port/zos390/omrgetsysname.c

@@ -21,6 +21,7 @@
  *******************************************************************************/
 
 #include <stdlib.h>
+#include <string.h>
 #include <sys/utsname.h>
 #include "omrgetsysname.h"
 

port/zos390/omrgetuserid.c

@@ -54,6 +54,7 @@ omrget_userid(char *userid, uintptr_t length)
 	uintptr_t result = 0;
 
 	userid[0] = '\0';
+	extern void _USERID(char *); /* defined in omruserid.s */
 
 	if (NULL != tmp_userid) {
 		char *ascname = NULL;