Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure compression method (tar or zip) and arguments #130

Open
TrogloGeek opened this issue Jan 7, 2013 · 5 comments
Open

Comments

@TrogloGeek
Copy link
Contributor

Am I the only one preferring tar over zip when working on *nix server ?
Or maybe zip is used to be compatible with an external program widely used I don't know ?

If not, I'm proposing myself to write a patch allowing the configuration of compression method and options (which would stay by default zip and -rq).
Please let me know if such a patch has any chance of being accepted or if this is a waste of my time. (Currently i'm modifying every release of this script to backup using tar).
If the answer is yes, please let me know if you have preferences on how it should be made (especially the config options).
I propose:

# zip|tar
DEFAULT_BACKUP_COMPRESSION_METHOD="zip"
DEFAULT_BACKUP_COMPRESSION_OPTS="-rq"

being used in both world/complete backup, but it probably isn't the better way to do it...

@kjkazinski
Copy link
Contributor

TrogloGeek,
 
You realize that a tar file is not compressed which is why I think zip is used.  Tar just puts your back up in file order (ie. like a tape).
 
Ken

--- On Mon, 1/7/13, TrogloGeek [email protected] wrote:

From: TrogloGeek [email protected]
Subject: [minecraft-server-manager] Allow to configure compression method (tar or zip) and arguments (#130)
To: "marcuswhybrow/minecraft-server-manager" [email protected]
Date: Monday, January 7, 2013, 8:23 AM

Am I the only one preferring tar over zip when working on *nix server ?
Or maybe zip is used to be compatible with an external program widely used I don't know ?
If not, I'm proposing myself to write a patch allowing the configuration of compression method and options (which would stay by default zip and -rq).
Please let me know if such a patch has any chance of being accepted or if this is a waste of my time. (Currently i'm modifying every release of this script to backup using tar).
If the answer is yes, please let me know if you have preferences on how it should be made (especially the config options).

Reply to this email directly or view it on GitHub.

@marcuswhybrow
Copy link

MSM creates WorldEdit compatible backups. WorldEdit can only work with zip files as tar does not have an index of the files contained within, which WorldEdit requires.

I think adding a tar option would be a good idea, but I would also add a disclaimer regarding the effects on WorldEdit.

@marcuswhybrow
Copy link

@TrogloGeek @kjkazinski I assumed we meant tar.gz.

@TrogloGeek
Copy link
Contributor Author

I meant tar.gz|tar.bz2 indeed.
I ran tests with bz2, compression difference is not that much high so I won't develop it for now, probably later.

@cameroncros
Copy link

Tar also has the benefit of not running out. Of ram during backups when ram is limited. My server fails to backup becuase y world is significantly larger than the available ram.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants