Skip to content

if install fails silently lead to empty buildcheck.gypi leading to super hard to read errors #30

Description

@axel7083

Description

The following run target may lead to very complicated errors

https://github.com/mscdex/cpu-features/blob/2faca5705cddb7ac388ad2d5e2242b7a7d427f3c/package.json#L16C38-L16C53

When running pnpm install on our repository, it try to build the package, and in my case was failing, but since it is optional build, it was kinda failing in silence, BUT it was creating a buildcheck.gypi empty file, and this started a 4 hours journey trying to figure out the issue.

I would have save so much time if the buildcheck.js was creating the buildcheck.gypi file instead of piping through >.

I am open to make the PR if this is an acceptable change.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions