Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-generate stable unique ID for each accordion that can be overridden by custom anchor #4

Closed
mrwweb opened this issue Nov 22, 2021 · 2 comments
Closed

Auto-generate stable unique ID for each accordion that can be overridden by custom anchor #4

mrwweb opened this issue Nov 22, 2021 · 2 comments

Comments

@mrwweb
Copy link
Owner

mrwweb commented Nov 22, 2021 •
edited
Loading

@mrwweb
Copy link
Owner Author

mrwweb commented Nov 29, 2021

I tried using the clientId but it changes any time the order of blocks changes, so doesn't seem to be stable enough to fulfill my purposes.

@mrwweb
Copy link
Owner Author

mrwweb commented Dec 2, 2021

As of #12, blocks now have a unique ID (the block's clientId). However that is unstable. For now, I've included a comment in the front-end code warning against ever linking to that ID and encouraging folks to set a custom ID with the block's "HTML anchor" setting.

@mrwweb mrwweb closed this as completed Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mrwweb