Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom coin configuration for BIP49 or others #4

Open
sandrocsimas opened this issue Oct 4, 2024 · 12 comments
Open

Allow custom coin configuration for BIP49 or others #4

sandrocsimas opened this issue Oct 4, 2024 · 12 comments

Comments

@sandrocsimas
Copy link
Contributor

sandrocsimas commented Oct 4, 2024

Thanks for the awesome library!
I was wondering if there's a way to use BIP49 with a configuration not listed here.
If not, would it be possible to add support for new cryptocurrencies in this library?
It seems like the fromSeed method could potentially accept a custom configuration.

@mrtnetwork
Copy link
Owner

Thanks for the awesome library! I was wondering if there's a way to use BIP49 with a configuration not listed here. If not, would it be possible to add support for new cryptocurrencies in this library? It seems like the fromSeed method could potentially accept a custom configuration.

Hi, thanks

Different coins use different cryptographic standards, and depending on that, you can use specific tools for key generation.
Here are some options for generating keys with different cryptography standards:

Bip32Slip10Secp256k1
Bip32Slip10Ed25519
CardanoIcarusBip32
Bip32KholawEd25519
Bip32Slip10Ed25519Blake2b
Bip32Slip10Nist256p1

There are also specific tools for certain coin standards, like:
Bip44Coins
Bip49Coins
Bip84Coins
Bip86Coins
Cip1852Coins

which coin do you need?

@sandrocsimas
Copy link
Contributor Author

I'd like to generate keys for the Electra Protocol layer 2 (Omni XEP).
I was able to fork and create the config for this network. Let me know if you want me to submit a PR.

@sandrocsimas
Copy link
Contributor Author

Bip49 / Slip44 / secp256k1

@mrtnetwork
Copy link
Owner

Bip49 / Slip44 / secp256k1

Apologies for the delay. Could you please clarify exactly what you need? I’ll review it and either add it to the package or submit a pull request.

@sandrocsimas
Copy link
Contributor Author

@mrtnetwork, I need to generate wallets for crypto not listed in your project. Basically, this:
https://github.com/sandrocsimas/blockchain_utils/commit/15b2d3bc076eb22e681767215b13ada7df7b7d55

@mrtnetwork
Copy link
Owner

@mrtnetwork, I need to generate wallets for crypto not listed in your project. Basically, this: sandrocsimas@15b2d3b

I will consider for the next update

@sandrocsimas
Copy link
Contributor Author

Thank you, @mrtnetwork. If you're planning to add support for the Electra protocol, I’d recommend holding off for now as I'm still creating and testing the wallet.
But if you're just considering making fromSeed and other functions more flexible to support custom cryptocurrencies, that would be fantastic!

@sandrocsimas
Copy link
Contributor Author

Hi @mrtnetwork, I created a PR for this repository and another for bitcoin_base. Both to complete the integration with OmniXEP. Many thanks!

@sandrocsimas
Copy link
Contributor Author

It would still be nice to have a generic interface, so people can add their own coin config, without needing to submit a PR.

@sandrocsimas
Copy link
Contributor Author

sandrocsimas commented Dec 9, 2024

@mrtnetwork, are you planning to release a new version of blockchain_utils and bitcoin_base soon? I'd love to get rid of my forks and launch OmniXEP mobile wallet without them, hehe.

@mrtnetwork
Copy link
Owner

@mrtnetwork, are you planning to release a new version of blockchain_utils and bitcoin_base soon? I'd love to get rid of my forks and launch OmniXEP mobile wallet without them, hehe.

hi, a week ago I published them in pub dev with OmniXEP features.

@sandrocsimas
Copy link
Contributor Author

Oh, nice, I'll take a look. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants