From c027f54453061c725fb22dc67af682ee9fa5dff6 Mon Sep 17 00:00:00 2001 From: Marc Rousavy Date: Tue, 12 Nov 2024 20:15:50 +0100 Subject: [PATCH] fix: Fix returning arrays of primitives not being properly sized in Java (#328) --- packages/nitrogen/src/syntax/kotlin/KotlinCxxBridgedType.ts | 3 +-- .../generated/android/c++/JHybridTestObjectSwiftKotlinSpec.cpp | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/packages/nitrogen/src/syntax/kotlin/KotlinCxxBridgedType.ts b/packages/nitrogen/src/syntax/kotlin/KotlinCxxBridgedType.ts index e1ec4c755..355d9f003 100644 --- a/packages/nitrogen/src/syntax/kotlin/KotlinCxxBridgedType.ts +++ b/packages/nitrogen/src/syntax/kotlin/KotlinCxxBridgedType.ts @@ -656,8 +656,7 @@ export class KotlinCxxBridgedType implements BridgedType<'kotlin', 'c++'> { return ` [&]() { size_t __size = ${parameterName}->size(); - std::vector<${itemType}> __vector; - __vector.reserve(__size); + std::vector<${itemType}> __vector(__size); ${parameterName}->getRegion(0, __size, __vector.data()); return __vector; }() diff --git a/packages/react-native-nitro-image/nitrogen/generated/android/c++/JHybridTestObjectSwiftKotlinSpec.cpp b/packages/react-native-nitro-image/nitrogen/generated/android/c++/JHybridTestObjectSwiftKotlinSpec.cpp index fb5e65596..9ba34084f 100644 --- a/packages/react-native-nitro-image/nitrogen/generated/android/c++/JHybridTestObjectSwiftKotlinSpec.cpp +++ b/packages/react-native-nitro-image/nitrogen/generated/android/c++/JHybridTestObjectSwiftKotlinSpec.cpp @@ -250,8 +250,7 @@ namespace margelo::nitro::image { }()); return [&]() { size_t __size = __result->size(); - std::vector __vector; - __vector.reserve(__size); + std::vector __vector(__size); __result->getRegion(0, __size, __vector.data()); return __vector; }();