From 582eab0a8ba1299654d646705d80b3d2b43532bd Mon Sep 17 00:00:00 2001 From: Marc Rousavy Date: Mon, 16 Sep 2024 14:42:58 +0200 Subject: [PATCH] fix: Use `nativeOrder` for ByteBuffer order --- .../android/src/main/cpp/core/ByteBufferArrayBuffer.hpp | 2 +- .../android/src/main/cpp/core/JArrayBuffer.hpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/react-native-nitro-modules/android/src/main/cpp/core/ByteBufferArrayBuffer.hpp b/packages/react-native-nitro-modules/android/src/main/cpp/core/ByteBufferArrayBuffer.hpp index adce2a747..fa79c2b76 100644 --- a/packages/react-native-nitro-modules/android/src/main/cpp/core/ByteBufferArrayBuffer.hpp +++ b/packages/react-native-nitro-modules/android/src/main/cpp/core/ByteBufferArrayBuffer.hpp @@ -21,7 +21,7 @@ using namespace facebook; class ByteBufferArrayBuffer final : public ArrayBuffer { public: explicit ByteBufferArrayBuffer(const jni::alias_ref& byteBuffer) : _byteBuffer(jni::make_global(byteBuffer)) { - _byteBuffer->order(jni::JByteOrder::bigEndian()); + _byteBuffer->order(jni::JByteOrder::nativeOrder()); } public: diff --git a/packages/react-native-nitro-modules/android/src/main/cpp/core/JArrayBuffer.hpp b/packages/react-native-nitro-modules/android/src/main/cpp/core/JArrayBuffer.hpp index b9b92c856..61da1fe1b 100644 --- a/packages/react-native-nitro-modules/android/src/main/cpp/core/JArrayBuffer.hpp +++ b/packages/react-native-nitro-modules/android/src/main/cpp/core/JArrayBuffer.hpp @@ -78,12 +78,12 @@ class JArrayBuffer final : public jni::HybridClass { size_t size = _arrayBuffer->size(); if (copyIfNeeded) { auto buffer = jni::JByteBuffer::allocateDirect(size); - buffer->order(jni::JByteOrder::bigEndian()); + buffer->order(jni::JByteOrder::nativeOrder()); memcpy(buffer->getDirectAddress(), _arrayBuffer->data(), size); return buffer; } else { auto buffer = jni::JByteBuffer::wrapBytes(_arrayBuffer->data(), size); - buffer->order(jni::JByteOrder::bigEndian()); + buffer->order(jni::JByteOrder::nativeOrder()); return buffer; } }