-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
files.upload method is deprecated. Upcoming breakage of slackr::file_upload()
#200
Comments
Thanks for putting this in! I'll look into it in the next couple weeks. I suspect it'll be a pretty straightforward change, but I also haven't touched the tests or anything in a year or two (and my engineering skills are better now than they were then :P), so there are probably other flaky breakages. Feel free to put in a PR for this if you want. I'd like to bundle in a test change that adds mocks to all the API calls instead of calling the real APIs from CI as well. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hey Matt, think you can help an old friend by doing this? Thanks! |
@orioles-analytics whoever you are, I'll try to do it this week or next 😄 |
😁 thank you! |
just put in #202 to hopefully fix this - you should be able to install from GH. let me know if anyone runs into any issues! I'll try to push a release to CRAN at some point. Going to close this for now, feel free to reopen |
The Slack files.upload method is being deprecated. New applications created after May 8th will not be able to use it and pre-existing apps will loose access in March of 2025. There are new methods to replace it files.getUploadURLExternal and files.completeUploadExternal.
We'll need to retool to continue to have file attachment functionality. Opening a tracking issue here for anyone (myself included) that may have time to work up a PR.
The text was updated successfully, but these errors were encountered: