Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mashupsdk/certmanager.go:19:16: undefined: MashupServerClient #6

Open
gedw99 opened this issue Apr 22, 2022 · 10 comments
Open

mashupsdk/certmanager.go:19:16: undefined: MashupServerClient #6

gedw99 opened this issue Apr 22, 2022 · 10 comments

Comments

@gedw99
Copy link

gedw99 commented Apr 22, 2022

for make based builds of gio and fyne i always get

mashupsdk/certmanager.go:19:16: undefined: MashupServerClient

@gedw99
Copy link
Author

gedw99 commented Apr 22, 2022

on the other branch ( https://github.com/mrjrieke/nute/tree/mashup_v2) , i get the same but more issues.

➜  nute git:(mashup_v2) ✗ make helloworldgio
go build -tags "gioboot" -o="./examples/helloworld/bin/hellogio" -ldflags="-X ..Version=ed050eb911f56924631aa8151ffd14de5bf3d8e1 -X ..Commit=ed050eb911f56924631aa8151ffd14de5bf3d8e1 -X ..BuildTime=2022-04-22_18:35:02_+0200" ./examples/helloworld/hellogio/main.go
# tini.com/nute/mashupsdk
mashupsdk/certmanager.go:19:16: undefined: MashupServerClient
mashupsdk/common.go:13:24: undefined: MashupDisplayHint
mashupsdk/common.go:14:54: undefined: MashupDetailedElementBundle
mashupsdk/common.go:14:85: undefined: MashupElementStateBundle
mashupsdk/common.go:15:47: undefined: MashupElementStateBundle

I am on Mac btw and go 1.8

@gedw99
Copy link
Author

gedw99 commented Apr 22, 2022

so i progressed to:

nute git:(mashup_v2) ✗ protoc --go_out=. --go_opt=paths=source_relative --go-grpc_out=. --go-grpc_opt=paths=source_relative mashupsdk/mashupsdk.proto

This does not seem to work..

nute git:(mashup_v2) ✗ make mashupsdk                                                                                                                
make: `mashupsdk' is up to date.

SO then i can it seems get past the previous issues to:

nute git:(mashup_v2) ✗ make helloworldgio
go build -tags "gioboot" -o="./examples/helloworld/bin/hellogio" -ldflags="-X ..Version=ed050eb911f56924631aa8151ffd14de5bf3d8e1 -X ..Commit=ed050eb911f56924631aa8151ffd14de5bf3d8e1 -X ..BuildTime=2022-04-22_18:41:03_+0200" ./examples/helloworld/hellogio/main.go
# gioui.org/app
../../../../pkg/mod/github.com/mrjrieke/[email protected]/app/os_macos.go:356:10: cnf.center undefined (type Config has no field or method center, but does have Center)
make: *** [helloworldgio] Error 2

@mrjrieke
Copy link
Owner

You will need protoc installed. Think it comes from grpc

@mrjrieke
Copy link
Owner

You can find install instructions here: https://grpc.io/docs/protoc-installation/#install-pre-compiled-binaries-any-os

@mrjrieke
Copy link
Owner

I’ll try to update readme next time I’m coding

@mrjrieke
Copy link
Owner

mrjrieke commented Apr 22, 2022

so i progressed to:

nute git:(mashup_v2) ✗ protoc --go_out=. --go_opt=paths=source_relative --go-grpc_out=. --go-grpc_opt=paths=source_relative mashupsdk/mashupsdk.proto

This does not seem to work..

nute git:(mashup_v2) ✗ make mashupsdk                                                                                                                
make: `mashupsdk' is up to date.

SO then i can it seems get past the previous issues to:

nute git:(mashup_v2) ✗ make helloworldgio
go build -tags "gioboot" -o="./examples/helloworld/bin/hellogio" -ldflags="-X ..Version=ed050eb911f56924631aa8151ffd14de5bf3d8e1 -X ..Commit=ed050eb911f56924631aa8151ffd14de5bf3d8e1 -X ..BuildTime=2022-04-22_18:41:03_+0200" ./examples/helloworld/hellogio/main.go
# gioui.org/app
../../../../pkg/mod/github.com/mrjrieke/[email protected]/app/os_macos.go:356:10: cnf.center undefined (type Config has no field or method center, but does have Center)
make: *** [helloworldgio] Error 2

I don’t have a Mac unfortunately but would love to see that implemented! My gio fork needs a pull request to implement that functionality for Mac.

@gedw99
Copy link
Author

gedw99 commented Apr 23, 2022

Hey @mrjrieke

Yeah it would be cool if it works on all OS's. Just not sure which bits need fixing for Mac.

This error is not OS specific . You agree ?

nute git:(mashup_v2) ✗ make helloworldgio
go build -tags "gioboot" -o="./examples/helloworld/bin/hellogio" -ldflags="-X ..Version=ed050eb911f56924631aa8151ffd14de5bf3d8e1 -X ..Commit=ed050eb911f56924631aa8151ffd14de5bf3d8e1 -X ..BuildTime=2022-04-22_18:41:03_+0200" ./examples/helloworld/hellogio/main.go
# gioui.org/app
../../../../pkg/mod/github.com/mrjrieke/[email protected]/app/os_macos.go:356:10: cnf.center undefined (type Config has no field or method center, but does have Center)
make: *** [helloworldgio] Error 2

Is this the error that is Mac specific ?


➜  nute git:(mashup_v2) ✗ make helloworldgio
go build -tags "gioboot" -o="./examples/helloworld/bin/hellogio" -ldflags="-X ..Version=ed050eb911f56924631aa8151ffd14de5bf3d8e1 -X ..Commit=ed050eb911f56924631aa8151ffd14de5bf3d8e1 -X ..BuildTime=2022-04-22_18:35:02_+0200" ./examples/helloworld/hellogio/main.go
# tini.com/nute/mashupsdk
mashupsdk/certmanager.go:19:16: undefined: MashupServerClient
mashupsdk/common.go:13:24: undefined: MashupDisplayHint
mashupsdk/common.go:14:54: undefined: MashupDetailedElementBundle
mashupsdk/common.go:14:85: undefined: MashupElementStateBundle
mashupsdk/common.go:15:47: undefined: MashupElementStateBundle

@mrjrieke
Copy link
Owner

I am on Mac btw and go 1.8

This is a bit surprising it works at all here... Since in my go.mod, I specify:
go 1.17

I think the executable created by go 1.17 are markedly faster than those created by 1.8, so worth the upgrade if you can make it. :)

@mrjrieke
Copy link
Owner

mrjrieke commented Apr 23, 2022

.... github.com/mrjrieke/[email protected]/app/os_macos.go:356:10

That part is most definitely mac specific. If you look at the top of that file (os_macos.go), you'll see a build tag that targets Mac OS. So when you compile on your mac, it will compile that specific file. On my Linux, it compiles a different file in the same directory.

This second bit looks like grpc might not have run, but it might be something else??:
mashupsdk/certmanager.go:19:16: undefined: MashupServerClient
mashupsdk/common.go:13:24: undefined: MashupDisplayHint

These missing definitions are generated in two separate files.
MashupServerClient-> should be in mashupsdk/mashupsdk_grpc.pb.go
MashupDisplayHint->should be in mashupsdk/mashupsdk.pb.go

I saw you ran this, so that's a good sign:
make mashupsdk
make: `mashupsdk' is up to date.

You know.... upgrading to go 1.17 might actually fix this if it's a package finding issue. Might be specific to go 1.8 on a mac even.

@gedw99
Copy link
Author

gedw99 commented Apr 26, 2022

I was using go 1.8 when I write the issue. So upgrading won’t help.

yep I did run the proto code gen.

As for the max specific code, I will won’t be able to work on it for a while - wish I could though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants