GLTFLoader: assign unique names to children of cloned refs in _getNod… #30091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes to the mesh primitive names will be a breaking change for R3F's gltfjsx and Threlte's gltf. We can do that, but to avoid back-to-back breaking changes I think it probably needs to happen at the same time as: Together I think the two changes will need some pretty careful testing to make sure GLTFLoader is producing a scene graph (structure, names, userDatas) that we are comfortable maintaining. |
|
Seems reasonable to me to batch these breaking changes together. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eRef() (fixes #30090)
Related issue: #30090
Description
When cloning a reference the children of the cloned reference have the same names as the children of the original reference. This causes duplicate names for example when dealing with meshes that have multiple primitives and that are instantiated multiple times.
This pull request attempts to change this by applying the same
_instance_Xsuffix applied to the reference name to its children. Another possible solution might be to apply createUniqueName() on the names of cloned children. Let me know if another solution than the current is preferred and I'd be happy to change it.