Add minimal test suite to check any regression and prove bug fixing

Author: nicolas-DH

README.md

@@ -56,4 +56,8 @@ Celery's [user guide][1]. Send tasks from signal handlers without fear!
             print_model.delay(model_pk)
             transaction.commit()
 
+## Run test suite
+
+        $ python setup.py test
+
 [1]: http://celery.readthedocs.org/en/latest/userguide/tasks.html#database-transactions

setup.py

@@ -1,10 +1,39 @@
 # coding=utf-8
-from setuptools import setup, find_packages
+import os
+import sys
 
+from setuptools import setup, Command, find_packages
+
+
+class RunTests(Command):
+    """RunTests class borrowed from django-celery project
+    """
+    description = 'Run the django test suite from the tests dir.'
+    user_options = []
+    extra_args = []
+
+    def run(self):
+        from django.core.management import execute_from_command_line
+        settings_module_name = 'tests.settings'
+        os.environ['DJANGO_SETTINGS_MODULE'] = os.environ.get(
+                                                    'DJANGO_SETTINGS_MODULE',
+                                                    settings_module_name)
+        prev_argv = sys.argv[:]
+        try:
+            sys.argv = [__file__, 'test'] + self.extra_args
+            execute_from_command_line(argv=sys.argv)
+        finally:
+            sys.argv[:] = prev_argv
+
+    def initialize_options(self):
+        pass
+
+    def finalize_options(self):
+        pass
 
 setup(
     name="django-celery-transactions",
-    version="0.1.3",
+    version="0.1.4",
     description="Django transaction support for Celery tasks.",
     long_description="See https://github.com/chrisdoble/django-celery-transactions",
     author="Chris Doble",
@@ -15,6 +44,7 @@
     install_requires=[
         "celery>=2.2.7",
         "Django>=1.2.4",
+        "django-celery>=2.2.7",
     ],
     classifiers=[
         "Framework :: Django",
@@ -24,4 +54,5 @@
         "Programming Language :: Python",
         "Topic :: Database",
     ],
+    cmdclass={'test': RunTests},
 )

tests.settings

@@ -0,0 +1,18 @@
+__doc__ = """Minimal django settings to run manage.py test command"""
+
+import djcelery
+djcelery.setup_loader()
+
+DATABASES = {
+    'default': {
+        'ENGINE': 'django.db.backends.sqlite3',
+        'NAME': __name__,
+    }
+}
+
+CELERY_ALWAYS_EAGER = True
+CELERY_EAGER_PROPAGATES_EXCEPTIONS = True
+
+INSTALLED_APPS = ('tests',
+                  'djcelery',
+                  )

tests/__init__.py

@@ -0,0 +1,49 @@
+from djcelery_transactions import task
+from celery.registry import tasks
+from django.db import transaction
+from django.test import TransactionTestCase
+
+my_global = []
+
+marker = object()
+
+@task
+def my_task():
+    my_global.append(marker)
+
+tasks.register(my_task)
+
+class SpecificException(Exception):
+    pass
+
+class DjangoCeleryTestCase(TransactionTestCase):
+    """Test djcelery transaction safe task manager
+    """
+    def tearDown(self):
+        my_global[:] = []
+
+    def test_commited_transaction_fire_task(self):
+        """Check that task is consumed when no exception happens
+        """
+
+        @transaction.commit_on_success
+        def do_something():
+            my_task.delay()
+
+        do_something()
+        self.assertTrue(my_global[0] is marker)
+
+    def test_rollbacked_transaction_discard_task(self):
+        """Check that task is not consumed when exception happens
+        """
+
+        @transaction.commit_on_success
+        def do_something():
+            my_task.delay()
+            raise SpecificException
+        try:
+            do_something()
+        except SpecificException:
+            self.assertFalse(my_global)
+        else:
+            self.fail('Exception not raised')