Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicon not captured #2

Open
mpclarkson opened this issue Jul 23, 2015 · 1 comment
Open

Favicon not captured #2

mpclarkson opened this issue Jul 23, 2015 · 1 comment

Comments

@mpclarkson
Copy link
Owner

http://www.harley-davidson.com/content/h-d/en_AU/home.html//favicon.ico

@karstennilsen
Copy link

karstennilsen commented Jun 25, 2018

The problem is that with endRedirect all redirects are first processed. When this is not to a root path e.g. http://www.harley-davidson.com/content/h-d/en_AU/home.html or https://gmail.com redirects to https://accounts.google.com/ServiceLogin?service=mail&passive=true&rm=false&continue=https://mail.google.com/mail/&ss=1&scc=1&ltmpl=default&ltmplcache=2&emr=1&osid=1, you enter an unsupported situation.

E.g. on line 155 of Scraper.php there should be a something that takes the base path in stead of the full $url
Line 155: $href = $url . '/' . $href; //Todo: Improve this

Need fixing indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants