Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

experiment-detail page: back button broken #124

Closed
jaredhirsch opened this issue Oct 6, 2015 · 6 comments
Closed

experiment-detail page: back button broken #124

jaredhirsch opened this issue Oct 6, 2015 · 6 comments
Assignees
Milestone

Comments

@jaredhirsch
Copy link
Member

Seems like the history / pushState behavior needs some work.

STR:

  1. Load an experiment detail page
  2. Hit the 'back' button
  3. The 'home' route is shown in the urlbar, but the 'home' page doesn't load
@lmorchard
Copy link
Contributor

@meandavejustice Was this fixed by PR #142?

@lmorchard lmorchard modified the milestone: MOZLANDO! Nov 4, 2015
@meandavejustice
Copy link
Contributor

Need to do some heavier testing here, I have a hunch it may be an issue with ampersand's router in firefox.

@meandavejustice
Copy link
Contributor

This actually seems to be a difference in the interpretation of the pushstate spec in firefox vs blink.

Here are some bugs:
https://bugzilla.mozilla.org/show_bug.cgi?id=1185420
https://bugzilla.mozilla.org/show_bug.cgi?id=976020
https://bugzilla.mozilla.org/show_bug.cgi?id=1059382

@lmorchard
Copy link
Contributor

Hmm, this bug is weird.

If I hit /home, click on an experiment, then hit back - it seems to work as expected. I can click back & forth as much as I want.

But, if I hit /home, click on an experiment, focus on the URL bar & hit return (not quite a reload), then hit back - things break such that /home never appears despite URL bar changes.

@meandavejustice
Copy link
Contributor

Right, that's what I'm experiencing too :(

On Fri, Nov 6, 2015 at 1:47 PM, Les Orchard [email protected]
wrote:

Hmm, this bug is weird.

If I hit /home, click on an experiment, then hit back - it seems to work
as expected.

But, if I hit /home, click on an experiment, reload*, then hit back -
things break such that /home never loads.


Reply to this email directly or view it on GitHub
#124 (comment).

lmorchard added a commit to lmorchard/testpilot that referenced this issue Nov 10, 2015
lmorchard added a commit to lmorchard/testpilot that referenced this issue Nov 10, 2015
lmorchard added a commit to lmorchard/testpilot that referenced this issue Nov 10, 2015
@lmorchard
Copy link
Contributor

Trying this as an upstream fix to Ampersand, just for the sake of completeness

AmpersandJS/ampersand-router#49

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants