Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename request for AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY #2164

Open
skyf0l opened this issue May 3, 2024 · 1 comment · May be fixed by #2210
Open

Rename request for AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY #2164

skyf0l opened this issue May 3, 2024 · 1 comment · May be fixed by #2210
Labels
good first bug For new comers

Comments

@skyf0l
Copy link

skyf0l commented May 3, 2024

It would be nice to rename these variables to SCCACHE_ACCESS_KEY/SCCACHE_SECRET_KEY or SCCACHE_AWS_ACCESS_KEY/SCCACHE_AWS_SECRET_KEY to be consistent with all the other variables used by sccache.

Moreover, it's impossible to use another AWS key of the same name for something else simultaneously with sccache.

It also might be a good idea to add these variables directly to the sccache config file.
@skyf0l skyf0l changed the title Rename rename for AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY Rename request for AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY May 3, 2024
@sylvestre
Copy link
Collaborator

Thanks. Pr welcome!

@sylvestre sylvestre added the good first bug For new comers label May 12, 2024
@Saruniks Saruniks linked a pull request Jun 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first bug For new comers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support to specify credentials for S3 explicitly Saruniks/my-custom-sccache
2 participants
@sylvestre @skyf0l