Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameters for "6244" should actually be "6144" #26

Open
alax opened this issue Jun 14, 2014 · 2 comments
Open

Parameters for "6244" should actually be "6144" #26

alax opened this issue Jun 14, 2014 · 2 comments

Comments

@alax
Copy link

alax commented Jun 14, 2014

"6244" is definitely a typo, since it the spec states 6144 and 6244 is not divisible by 8.
@pyramids
Copy link

I suppose you are referring to

node-srp/lib/params.js

Line 105 in 869ed98

6244: {
?

@alax
Copy link
Author

alax commented Jun 14, 2014

Yes, that's correct! It just needs a simple change to 6144 and it should be all good.

pyramids added a commit to pyramids/node-srp that referenced this issue Jun 15, 2014
@pyramids
6144 bit parameter change requested by issue mozilla#26
86b656a 
Merely applying the suggested change; did not check for correctness (review, please!).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alax @pyramids