Skip to content

Commit 9c32efd

Browse files
authored
Improve logging for build regression analysis (#1162)
* Fix erroneous logging message about errors with no previous occurrence * Improve logging a bit
1 parent b557a33 commit 9c32efd

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

mozci/push.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1139,21 +1139,24 @@ def check_build_regressions(self) -> list[Task]:
11391139
and task.is_build_failure()
11401140
]
11411141
if not build_regressions:
1142-
logger.info("No regression detected.")
1142+
logger.info("No build regression detected.")
11431143
return []
11441144

1145-
new_regressions = sum(occurrences > 0 for _, occurrences in build_regressions)
1145+
new_regressions = sum(past_occurrences == 0 for _, past_occurrences in build_regressions)
11461146
logger.info(
11471147
f"Detected {len(build_regressions)} build tasks that may contain a regression "
1148-
f"({new_regressions} potentially introduced by this push)."
1148+
f"({new_regressions} were never seen before)."
11491149
)
11501150

1151-
# Filter tasks by retrigger criteria
1152-
return [
1151+
tasks_to_retrigger = [
11531152
task
11541153
for task, count in build_regressions
11551154
if task.should_retrigger_build(previous_occurrences_count=count)
11561155
]
1156+
if not tasks_to_retrigger:
1157+
logger.info("No build task should be retriggered.")
1158+
logger.info("{len(tasks)} build tasks should be retriggered.")
1159+
return tasks_to_retrigger
11571160

11581161
def classify_regressions(
11591162
self,

0 commit comments

Comments
 (0)