Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FXDE in-product pages include navbar #14949

Open
janbrasna opened this issue Aug 1, 2024 · 1 comment · May be fixed by #14936
Open

FXDE in-product pages include navbar #14949

janbrasna opened this issue Aug 1, 2024 · 1 comment · May be fixed by #14936

Comments

@janbrasna
Copy link
Contributor

janbrasna commented Aug 1, 2024

When compared to release/beta:
https://www-dev.allizom.org/en-CA/firefox/127.0/whatsnew/
https://www-dev.allizom.org/en-CA/firefox/126.0beta/whatsnew/
and nightly:
https://www-dev.allizom.org/en-US/firefox/80.0a1/whatsnew/

the WNPs and firstrun for aurora/developer currently start with the common layout masthead:
https://www-dev.allizom.org/en-US/firefox/102.0a2/whatsnew/
https://www-dev.allizom.org/en-US/firefox/92.0a2/whatsnew/
https://www-dev.allizom.org/en-US/firefox/83.0a2/firstrun/

(comparison aurora–beta:)
Screenshot 2024-08-01 at 15 07 34
(whatsnew aurora × nightly:)
Screenshot 2024-08-01 at 14 54 17
(firstrun aurora × nightly:)
Screenshot 2024-08-01 at 15 07 34

Is it intentional, or for consistency with other in-product pages this should also skip the masthead?

@janbrasna janbrasna linked a pull request Aug 1, 2024 that will close this issue
@janbrasna
Copy link
Contributor Author

janbrasna commented Aug 1, 2024

Why I'm raising this is that in #14936 this is being evened out for all channels in simplification, so the FXDE WNPs would also be header-less — therefore I've added the same treatment to its firstrun for consistency:

(current × removed:)
Screenshot 2024-08-01 at 15 14 45
Screenshot 2024-08-01 at 15 15 02

(Unless the navbar there is intentional, and I'll have to find a way to make the aurora in-product pages behave differently.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant