Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GTM Review] Review GTM space "data-link-name" #14940

Closed
Tracked by #14749
stephaniehobson opened this issue Jul 31, 2024 · 1 comment
Closed
Tracked by #14749

[GTM Review] Review GTM space "data-link-name" #14940

stephaniehobson opened this issue Jul 31, 2024 · 1 comment
Assignees

Comments

@stephaniehobson
Copy link
Contributor

stephaniehobson commented Jul 31, 2024

One-line summary

Review and publish GTM workspace "data-link-name"

Significant changes and points to review

All instances of data-link-name were removed from the code base in #14055. This GTM edit removes the trigger and Custom JavaScript variable that were helping smooth the transition from data-link-name to data-link-text.

Issue

Issue: #14055
Supporting bedrock changes: #14057

Testing

  • find an element with data-link-text
  • click it
  • make sure link_click still fires (hint: all the navigation menu items should have that attribute)
@alexgibson
Copy link
Member

Approved in GTM (I'll leave it to you to publish).

@alexgibson alexgibson removed the Needs Review Awaiting code review label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants