Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

Remove notion of editors #1952

Closed
leplatrem opened this issue Dec 3, 2021 · 1 comment
Closed

Remove notion of editors #1952

leplatrem opened this issue Dec 3, 2021 · 1 comment

Comments

@leplatrem
Copy link
Collaborator

The editors group is used to limit the users allowed to request review on a collection.

We don't really need that. Being able to write on the collection is enough to be allowed to request review. And there is no reason why a reviewer could not request a review too (since they have write perms on the collection).

This would allow to remove a lot of duplicated lists in our permissions manifests, because for collections whose group of editors is the same as reviewers, we would just have:

cid:
  permissions:
      write:
          - /buckets/main/groups/cid-reviewers

And for the collections which have editors that are not reviewers, we would do:

cid:
   permissions:
      write:
          - ldap:[email protected]
          - ldap:[email protected]
          - /buckets/main/groups/cid-reviewers

This issue was initially reported here Kinto/kinto-signer#733

But it makes more sense to keep track of it here, along with #1945, #1946, #1948.

@leplatrem
Copy link
Collaborator Author

Moved to mozilla/remote-settings#150

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant