Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[signingscript] support browser_specific_settings in _extension_id? #221

Open
escapewindow opened this issue May 27, 2020 · 1 comment
Open

[signingscript] support browser_specific_settings in _extension_id? #221

escapewindow opened this issue May 27, 2020 · 1 comment
Labels
good first issue Good for newcomers signingscript

Comments

@escapewindow
Copy link
Contributor

In https://github.com/mozilla-releng/scriptworker-scripts/blob/master/signingscript/src/signingscript/sign.py#L514-L534 , we hardcode our id to applications.gecko.id. It looks like it's also valid to set it to browser_specific_settings.gecko.id, which is more Chrome-compatible. Let's support both.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers signingscript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@escapewindow