fix(bitrisescript): only log Bitrise response content on error

This is actually very verbose and makes the Taskcluster logs very
difficult to read, so only log it on error.

Author: ahal

bitrisescript/src/bitrisescript/bitrise.py

@@ -87,6 +87,10 @@ async def request(self, endpoint: str, method: str = "get", **kwargs: Any) -> An
         while True:
             r = await self._client.request(method, url, **kwargs)
             log.debug(f"{method_and_url} returned HTTP code {r.status}")
+            if r.status >= 400:
+                log.debug(f"{method_and_url} returned JSON:\n{pformat(data)}")
+                r.raise_for_status()
+
             response = await r.json()
 
             if "data" not in response:
@@ -104,8 +108,6 @@ async def request(self, endpoint: str, method: str = "get", **kwargs: Any) -> An
                 break
             kwargs.setdefault("params", {})["next"] = next
 
-        log.debug(f"{method_and_url} returned JSON {pformat(data)}")
-
         return data
 
 

bitrisescript/tests/test_bitrise.py

@@ -102,8 +102,10 @@ async def test_bitrise_client_request(config, mocker, client, prefix, endpoint,
         {"Authorization": config["bitrise"]["access_token"]},
     )
 
+    response = mocker.AsyncMock()
+    response.status = 200
     m = mocker.patch.object(client._client, "request", return_value=Future())
-    m.return_value.set_result(mocker.AsyncMock())
+    m.return_value.set_result(response)
 
     if prefix:
         client.prefix = prefix