fix: default value for MOZ_FETCHES in integration test transform should be an empty object #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld be an empty json object
An empty string is not valid JSON:
>>> import json
>>> json.loads("")
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/bhearsum/.pyenv/versions/3.11.6/lib/python3.11/json/__init__.py", line 346, in loads
return _default_decoder.decode(s)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/bhearsum/.pyenv/versions/3.11.6/lib/python3.11/json/decoder.py", line 337, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/bhearsum/.pyenv/versions/3.11.6/lib/python3.11/json/decoder.py", line 355, in raw_decode
raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
hneiva
approved these changes
Dec 13, 2024
| @@ -42,7 +42,7 @@ def make_firefoxci_artifact_tasks(config, tasks): | |||
| # Add private artifacts | |||
| if "MOZ_FETCHES" in task_def["payload"].get("env", {}): | |||
| fetches = json.loads( | |||
| task_def["payload"].get("env", {}).get("MOZ_FETCHES", {}) | |||
| task_def["payload"].get("env", {}).get("MOZ_FETCHES", "{}") | |||
There was a problem hiding this comment.
super nitty: could also do a check if env := task_def["payload"].get("env"):.... for arguably more performance. But give this only runs once, it should be fine too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An empty string is not valid JSON: