Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't signoff on a rule update that previously didn't require signoffs #3312

Open
ahal opened this issue Feb 11, 2025 · 0 comments
Open

Can't signoff on a rule update that previously didn't require signoffs #3312

ahal opened this issue Feb 11, 2025 · 0 comments

Comments

@ahal
Copy link
Contributor

ahal commented Feb 11, 2025

We discovered that if you modify a rule that doesn't need a signoff to then require a signoff, the "Signoff" button stays disabled.

STR:
In Balrog stage, create any rule on the Firefox VPN : release-cdntest channel. No signoff is required. Modify the rule and update the channel to release*. Signoff is required for this update as expected.

Expected:
The rule update can be signed off on.

Actual:
The "Signoff" button is greyed out and no one can signoff.

The workaround here is to duplicate the rule rather than modify the old one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant