Prevent scheduling a new rule with a duplicate alias #3029
Conversation
michellemounde
requested review from
jcristau,
gbrownmozilla and
gabrielBusta
as code owners
michellemounde
force-pushed
the
duplicate-alias-scheduled-rule
branch
from
27e458b to
333df81
Compare
There was a problem hiding this comment.
This is an OK start, but more is needed. Specifically, we should reject duplicate aliases when:
- The alias exists in any row in the
rulestable - The alias exists in any row in the
rule_scheduled_changestable that meets both the following conditions:completeis Falsechange_typeisinsertorupdate
We also need tests for these cases in https://github.com/mozilla-releng/balrog/blob/main/tests/admin/views/test_rules.py
|
Ok @bhearsum will work on the changes. I have a question regarding the failing check. I've looked at the details but I am not sure how to fix the issue so that the check passes. |
That error looks unrelated to your change. It will probably fix itself the next time you push - don't worry about it. |
|
This ended up getting fixed in #3010 first. |
Fixes #2942
Before insert:
On insert:
