You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Over in #1738 (review), I forgot to pass down a transaction object from the service layer to the database layer. In production, there's certainly no use case where we wouldn't want a transaction. We should make them required at every layer.
This will complicated unit tests a bit, but a price worth paying to make impossible to forget to use a transaction.
The text was updated successfully, but these errors were encountered:
Over in #1738 (review), I forgot to pass down a
transaction
object from the service layer to the database layer. In production, there's certainly no use case where we wouldn't want a transaction. We should make them required at every layer.This will complicated unit tests a bit, but a price worth paying to make impossible to forget to use a transaction.
The text was updated successfully, but these errors were encountered: