Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make transactions required #1741

Open
bhearsum opened this issue Jan 20, 2021 · 0 comments
Open

make transactions required #1741

bhearsum opened this issue Jan 20, 2021 · 0 comments
Labels
db database layer

Comments

@bhearsum
Copy link
Contributor

Over in #1738 (review), I forgot to pass down a transaction object from the service layer to the database layer. In production, there's certainly no use case where we wouldn't want a transaction. We should make them required at every layer.

This will complicated unit tests a bit, but a price worth paying to make impossible to forget to use a transaction.

@bhearsum bhearsum added the db database layer label Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
db database layer
Projects
None yet
Development

No branches or pull requests

1 participant