Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cope with MozillaOnline builds sending unexpected system capabilities strings #1110

Open
bhearsum opened this issue Dec 20, 2019 · 0 comments
Labels
public public Balrog app/api (aus5.mozilla.org; aus-api.mozilla.org)

Comments

@bhearsum
Copy link
Contributor

I just noticed that some mozillaonline builds are sending update URLs such as:
https://aus5.mozilla.org/update/6/firefox/68.0.2/20190813150448/winnt_x86_64-msvc-x64/zh-cn/release-cck-mainwinfull-mozillaonline/windows_nt%206.1.1.0.7601%20%28x64%29/iset:sse4_2%2Cmem:16341/mozillaonline/2019.7/update.xml

Because the strings in the system capabilities section are lowercase (iset:sse4_2%2Cmem:16341), our parsing is not working correctly: https://github.com/mozilla/balrog/blob/dfd356a96820a88f05195ec5cd8d536fc5830e8d/auslib/web/public/client.py#L38

Which causes exceptions like: invalid literal for int() with base 10: 'mem:16341'

We should adjust our parsing logic to lowercase those strings before comparison, but it would be good to sync up whatever is creating those mozillaonline URLs with the rest of the client side code.

(Imported from https://bugzilla.mozilla.org/show_bug.cgi?id=1578474)

@bhearsum bhearsum added the public public Balrog app/api (aus5.mozilla.org; aus-api.mozilla.org) label Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
public public Balrog app/api (aus5.mozilla.org; aus-api.mozilla.org)
Projects
None yet
Development

No branches or pull requests

1 participant