Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verify history tables entries in tests #1089

Open
bhearsum opened this issue Dec 20, 2019 · 0 comments
Open

verify history tables entries in tests #1089

bhearsum opened this issue Dec 20, 2019 · 0 comments
Labels
tests unit/integration tests

Comments

@bhearsum
Copy link
Contributor

bug 1246993 describes a long standing bug where bad entries were made to history tables while making updates. If the tests for this code had verified the history table entries (in addition to the primary tables), this bug would never have been introduced.

We should make a point of always verifying the history table entries whenever we write tests that modify the database. This bug is to track updating all of the existing tests to do so.

(Imported from https://bugzilla.mozilla.org/show_bug.cgi?id=1405337)
@bhearsum bhearsum added the tests unit/integration tests label Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests unit/integration tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bhearsum