Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Onboarding.TermsOfService.PrivacyNoticeAgreement.v135 string is not l10n friendly #23930

Open
ItielMaN opened this issue Dec 21, 2024 · 4 comments

Comments

@ItielMaN
Copy link

ItielMaN commented Dec 21, 2024

https://pontoon.mozilla.org/he/firefox-for-ios/firefox-ios.xliff/?string=314023
The string reads Firefox cares about your privacy. Read more in our Privacy Notice. when parsed, but this doesn't work in some locales such as Hebrew, where the "our" comes after the "Privacy Notice." string, making this being read as "Firefox cares about your privacy. Read more in Privacy Notice. our" when translated.

┆Issue is synchronized with this Jira Task

@ItielMaN
Copy link
Author

CC @Delphine

@Delphine
Copy link
Contributor

So would it not work if you're formatting the string as:
%1$@ cares about your privacy. Read more in %2$@ our

(there's no ending punctuation at the end of the string, so IIUC this workaround should work?)

@ItielMaN
Copy link
Author

@Delphine This would work only if I would remove the end punctuation from Onboarding.TermsOfService.PrivacyNoticeLink.v135, and add it to Onboarding.TermsOfService.PrivacyNoticeAgreement.v135.
But this seems like twisting the original strings too much...

@Delphine
Copy link
Contributor

Delphine commented Dec 30, 2024

Thanks for further explaining. I'll get something on file on bugzilla to fix this, and maybe you can use that workaround in the meantime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants