Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When FCL 0.6 is the default, bounding box code can be simplified #229

Open
AndyZe opened this issue Feb 28, 2023 · 1 comment
Open

When FCL 0.6 is the default, bounding box code can be simplified #229

AndyZe opened this issue Feb 28, 2023 · 1 comment

Comments

@AndyZe
Copy link
Member

AndyZe commented Feb 28, 2023

PR #210 had some #if - type stuff that can be simplified when the default FCL version is >0.5.

#if FCL_MAJOR_VERSION > 0 || FCL_MINOR_VERSION > 5
#include <fcl/geometry/shape/utility.h>
#endif
@peci1
Copy link
Contributor

peci1 commented Apr 21, 2024

I suggested these simplifications in #239 for ROS 2. Noetic can probably be left with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peci1 @AndyZe