Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notify.update does not change the message #200

Open
loretoparisi opened this issue Jul 24, 2018 · 1 comment
Open

notify.update does not change the message #200

loretoparisi opened this issue Jul 24, 2018 · 1 comment
Assignees

Comments

@loretoparisi
Copy link

loretoparisi commented Jul 24, 2018

Hi, looking at the code of update when the command is type

for (var cmd in commands) {
						switch (cmd) {
							case "type":
								this.$ele.removeClass('alert-' + self.settings.type);
								this.$ele.find('[data-notify="progressbar"] > .progress-bar').removeClass('progress-bar-' + self.settings.type);
								self.settings.type = commands[cmd];
								this.$ele.addClass('alert-' + commands[cmd]).find('[data-notify="progressbar"] > .progress-bar').addClass('progress-bar-' + commands[cmd]);
								break;

so if I do something like

//Update
            var notify = $.notify('<strong>Please wait while formatting output...', { allow_dismiss: false });
            
            setTimeout(function() {
                notify.update({ type:'success' }, '<strong>Success</strong> JSON response is now available');
            },1000 * 3);

it will not change the current alert message, right?

@mouse0270
Copy link
Owner

You are correct, however, this is something I should look into resolving.

@mouse0270 mouse0270 self-assigned this Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants