Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use in-memory component to implement the Actuator API #463

Closed
seeflood opened this issue Apr 11, 2022 · 2 comments
Closed

Use in-memory component to implement the Actuator API #463

seeflood opened this issue Apr 11, 2022 · 2 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@seeflood
Copy link
Member

seeflood commented Apr 11, 2022

What would you like to be added:
Currently our Actuator quickstart demo use the apollo component,which connects to the apollo server by default.
image

However, due to the GFW, the github workflow can not connect to the apollo server when running the tests:
image

see #456

To solve this issue, we can:

  • Use some in-memory component to implement the Actuator API.
    We can choose any one of the in-memory components, such as the state component, such as the pubsub component, etc.

  • modify the quickstart and use the configs/config_in_memory.json instead, so that the demo won't try to connect to the remote server.

Why is this needed:
To solve the issue above, and make the quickstart more stable and testable

@seeflood seeflood added good first issue Good for newcomers help wanted Extra attention is needed labels Apr 11, 2022
@seeflood seeflood changed the title doc: use in-memory component for Actuator quickstart Use in-memory component to implement the Actuator API Apr 12, 2022
@seeflood seeflood self-assigned this Apr 21, 2022
@akkw
Copy link
Contributor

akkw commented Apr 23, 2022

我想做这个,我们怎么沟通

@seeflood
Copy link
Member Author

@akkw 啊不好意思,这个功能我已经做好合并进去了,因为还在写文档 所以这个issue 没关……
可以看下其他感兴趣的事情哈,见 #108#470

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants