Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find a smart way to validate the conf in the typedConfig of networkRBAC plugin #630

Open
spacewander opened this issue Jul 4, 2024 · 1 comment
Open

Find a smart way to validate the conf in the typedConfig of networkRBAC plugin #630

spacewander opened this issue Jul 4, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@spacewander
Copy link
Member

Description

No response

Use Scenes

See

htnn/types/plugins/networkrbac/config.go

Line 115 in f7ce8fe

// Another TODO: do it more smartly
.

The TypedConfig is a wrapper of protobuf Any so it's not validated by the generated validation.
Maybe we can use reflect to get all the TypedConfig and check them with the real proto message? Or using other solution. The solution should also work with other TypedConfig

Advice

No response
@spacewander spacewander added the enhancement New feature or request label Jul 4, 2024
@spacewander
Copy link
Member Author

Relative: #629

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spacewander