You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Coming up on unintended behavior when we try to compare attributes of a parametric potential to a null string with determining what to write for XML handling.
The line in question only works for numpy<=1.24.3. Probably can fix this single line so unyt arrays are not compared to this null string, and we can avoid that becoming an issue.
This is currently handled in GMSO by pinning to numpy<=1.24.3. I'm going to leave this issue open though, as a reminder that in the near future, we either need to get a fix on the unyt side, or fix our logic.
Coming up on unintended behavior when we try to compare attributes of a parametric potential to a null string with determining what to write for XML handling.
The line in question only works for numpy<=1.24.3. Probably can fix this single line so unyt arrays are not compared to this null string, and we can avoid that becoming an issue.
gmso/gmso/core/parametric_potential.py
Line 220 in e488a03
The text was updated successfully, but these errors were encountered: