Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Commit

Permalink
feat: add startupProbe (#109)
Browse files Browse the repository at this point in the history
Fixes #98
  • Loading branch information
ekeih authored Sep 6, 2022
1 parent 7b4c1b6 commit 446343e
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 10 deletions.
3 changes: 2 additions & 1 deletion charts/generic/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ apiVersion: v2
name: generic
description: A chart for generic applications. Use this if you need to deploy something without wanting to build a fully fledged new helm chart.
type: application
version: 3.2.2
version: 3.3.0
maintainers:
- name: morremeyer
email: [email protected]
- name: ekeih
6 changes: 3 additions & 3 deletions charts/generic/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# generic

![Version: 3.2.2](https://img.shields.io/badge/Version-3.2.2-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)
![Version: 3.3.0](https://img.shields.io/badge/Version-3.3.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)

A chart for generic applications. Use this if you need to deploy something without wanting to build a fully fledged new helm chart.

Expand All @@ -9,6 +9,7 @@ A chart for generic applications. Use this if you need to deploy something witho
| Name | Email | Url |
| ---- | ------ | --- |
| morremeyer | <[email protected]> | |
| ekeih | | |

## Complex values

Expand Down Expand Up @@ -83,7 +84,6 @@ If you have environment variables set from ConfigMaps or Secrets, check out `env
| deploymentStrategy | object | `{}` | |
| env | list | `[]` | Directly set environment variables |
| envValueFrom | object | `{}` | Set environment variables from configMaps or Secrets |
| failedJobsHistoryLimit | string | `nil` | The number of failed finished jobs to retain. |
| fullnameOverride | string | `""` | |
| image.pullPolicy | string | `"IfNotPresent"` | |
| image.repository | string | `"nginx"` | |
Expand Down Expand Up @@ -129,5 +129,5 @@ If you have environment variables set from ConfigMaps or Secrets, check out `env
| serviceAccount.annotations | object | `{}` | Annotations to add to the service account |
| serviceAccount.create | bool | `true` | Specifies whether a service account should be created |
| serviceAccount.name | string | `""` | The name of the service account to use. If not set and create is true, a name is generated using the fullname template. |
| successfulJobsHistoryLimit | string | `nil` | The number of successful finished jobs to retain. |
| startupProbe | string | `nil` | Configure a startup probe for the pod |
| tolerations | list | `[]` | |
3 changes: 3 additions & 0 deletions charts/generic/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,9 @@ spec:
{{- with .Values.readinessProbe }}
readinessProbe: {{- toYaml . | nindent 12 }}
{{- end }}
{{- with .Values.startupProbe }}
startupProbe: {{- toYaml . | nindent 12 }}
{{- end }}
{{- with .Values.resources }}
resources: {{- toYaml . | nindent 12 }}
{{- end }}
Expand Down
9 changes: 3 additions & 6 deletions charts/generic/values.yaml
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
# -- The number of successful finished jobs to retain.
successfulJobsHistoryLimit: ~

# -- The number of failed finished jobs to retain.
failedJobsHistoryLimit: ~

# -- number of replicas
replicaCount: 1

Expand Down Expand Up @@ -79,6 +73,9 @@ readinessProbe:
path: /
port: http

# -- Configure a startup probe for the pod
startupProbe: ~

service:
type: ClusterIP
annotations: {}
Expand Down

0 comments on commit 446343e

Please sign in to comment.