Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPD: Wrongly annonces support for channels #19

Open
mxjeff opened this issue Jan 11, 2019 · 1 comment
Open

MPD: Wrongly annonces support for channels #19

mxjeff opened this issue Jan 11, 2019 · 1 comment
Labels
C-bug Category: This is a bug

Comments

@mxjeff
Copy link

mxjeff commented Jan 11, 2019

This issue is actually related to an issue found in an utility MPD client MPD_sima (also mentioned in #14).

Here is the ouptput of commands MPD command:

printf "commands\nclose\n" | nc localhost 6600 | grep -E '(subscribe|channels)' -
command: channels
command: subscribe
command: unsubscribe

mopidy should not expose channels capabilities if it does not implement it.

Cheers

@kingosticks
Copy link
Member

kingosticks commented Jan 18, 2019

Yeh, despite the wording:

Shows which commands the current user has access to.

It seems nonsensical to advertise anything that isn't actually implemented (yet).

Either remove the @protocol.commands.add decorator for all these non-implemented commands, or set list_command=False.

@jodal jodal transferred this issue from mopidy/mopidy Dec 20, 2019
@jodal jodal added the C-bug Category: This is a bug label Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug
Projects
None yet
Development

No branches or pull requests

3 participants