Skip to content

API: fedWireMessage is an object, not an array #358

@DennyWeinberg

Description

@DennyWeinberg

WIRE Version

v0.15.0

What were you trying to do?

I'm creating, parsing and validating WIRE files that contains multiple transactions.

What did you expect to see?

A parsed JSON structure containing all my fed wire messages.

What did you see?

A parsed JSON structure containing ONLY the last fed wire message, others are lost.

The problem is, the API JSON is not a list: https://moov-io.github.io/wire/api/#post-/files/create

{
  "ID": "3f2d23ee214",
  "fedWireMessage": {
    "ID": "3f2d23ee214",
...

So how could that hold multiple messages? fedWireMessage should be an array, not an object.

How can we reproduce the problem?

  1. Call the create API with a WIRE file that contains multiple messages
  2. Check the response, only one message is returned obviously because it's not an array

Activity

adamdecaf

adamdecaf commented on Nov 30, 2023

@adamdecaf
Member

Yea.. We'll need to make this change. I think a breaking change is appropriate since this is such a major bug.

atonks2

atonks2 commented on Nov 30, 2023

@atonks2
Contributor

Thanks @DennyWeinberg. I'll be addressing this one soon.

DennyWeinberg

DennyWeinberg commented on Jan 5, 2024

@DennyWeinberg
Author

Any news here?

atonks2

atonks2 commented on Jan 6, 2024

@atonks2
Contributor

I've been asking around for sample files to see how bulk/batch files should be formatted, but haven't been able to find anything.

I'll get back to researching this next week.

Denny-g6labs

Denny-g6labs commented on Apr 25, 2024

@Denny-g6labs

Any news here? :)

atonks2

atonks2 commented on Apr 25, 2024

@atonks2
Contributor

I haven't been able to find much info about how batch files should be formatted. Do you have any example files you can share @Denny-g6labs?

linked a pull request that will close this issue on May 6, 2024
atonks2

atonks2 commented on May 7, 2024

@atonks2
Contributor

@Denny-g6labs If you have the ability to run some files through PR #394, any feedback would be appreciated. I'd love to hear how those changes handle files from various financial institutions.

Denny-g6labs

Denny-g6labs commented on Jan 7, 2025

@Denny-g6labs

Hi,

unfortunately I still don't have sample files I can share, as they contain sensitive data.
However, I have some more information:

Basically - our customers can submit bulk wires by just using the standard wire formatting. Each separate wire needs to be separated by a carriage return, but that's the only unique instruction for submitting in a single bulk file!

I hope that helps, I'm going to ask for such a file and describe more in detail what I see, so you get a better idea.

Denny-g6labs

Denny-g6labs commented on Jan 7, 2025

@Denny-g6labs

Here a sample file that the core process software is able to use, there are two transactions in the wire file:
image
The separator is CRLF (\r\n) in my case.

Denny-g6labs

Denny-g6labs commented on Jan 7, 2025

@Denny-g6labs

Are you able to provide a Docker image with that PR? Unfortunately I'm not good at go and will have issue trying it out without (beta) image.

Denny-g6labs

Denny-g6labs commented on Jun 23, 2025

@Denny-g6labs

Any news here?
Can we merge or create a temporarily docker?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingenhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @adamdecaf@DennyWeinberg@atonks2@Denny-g6labs

      Issue actions

        API: fedWireMessage is an object, not an array · Issue #358 · moov-io/wire