Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version should update with new library version #157

Open
2 tasks
SergioCrisostomo opened this issue Nov 4, 2014 · 4 comments
Open
2 tasks

Latest version should update with new library version #157

SergioCrisostomo opened this issue Nov 4, 2014 · 4 comments
Milestone

Comments

@SergioCrisostomo
Copy link
Member

SergioCrisostomo commented Nov 4, 2014

Currently some pages are using the latest version of source code from the package.json file. This should be refactored so the latest version is assigned to a variable dynamically, adding fs.watch().

A example would how core gets the latest version to have in the download button

Tofix:

  • make a function out of var copyright so the year will always be right
  • core gets the latest version fomr package.json on server start <--- refactor


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@SergioCrisostomo SergioCrisostomo added this to the 1.2 milestone Nov 4, 2014
@ibolmo
Copy link
Member

ibolmo commented Nov 4, 2014

I didn't quite get that. Maybe a couple of source code links?

@SergioCrisostomo
Copy link
Member Author

@ibolmo yeah, sorry. Added a example above.

@ibolmo
Copy link
Member

ibolmo commented Nov 5, 2014

So is this a refactor (as in not broken, but it's fragile)?

@SergioCrisostomo
Copy link
Member Author

@ibolmo exactly. It works good but should be refactored until we release a new version of Core or More.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants