From 5315b52694c4cfe95d9015c418c686eb0fa20edc Mon Sep 17 00:00:00 2001 From: Andrey Date: Tue, 4 Jun 2024 23:50:38 +0300 Subject: [PATCH 1/2] Added raised error. --- engineapi/engineapi/actions.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/engineapi/engineapi/actions.py b/engineapi/engineapi/actions.py index bc0c6d74..38aac024 100644 --- a/engineapi/engineapi/actions.py +++ b/engineapi/engineapi/actions.py @@ -113,6 +113,10 @@ class LeaderboardAssignResourceError(Exception): pass +class LeaderboardPushScoreError(Exception): + pass + + BATCH_SIGNATURE_PAGE_SIZE = 500 logger = logging.getLogger(__name__) @@ -1717,6 +1721,7 @@ def add_scores( db_session.commit() except: db_session.rollback() + raise LeaderboardPushScoreError("Error committing scores") return leaderboard_scores From d5ba535a75c41a4a3cc5ba544eba76f5f2ebf523 Mon Sep 17 00:00:00 2001 From: Andrey Date: Tue, 4 Jun 2024 23:54:47 +0300 Subject: [PATCH 2/2] Add error handler. --- engineapi/engineapi/routes/leaderboard.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/engineapi/engineapi/routes/leaderboard.py b/engineapi/engineapi/routes/leaderboard.py index ce798cb2..a25c8462 100644 --- a/engineapi/engineapi/routes/leaderboard.py +++ b/engineapi/engineapi/routes/leaderboard.py @@ -779,6 +779,12 @@ async def leaderboard_push_scores( status_code=500, detail=f"Delete scores failed.", ) + except actions.LeaderboardPushScoreError as e: + logger.error(f"Add scores failed with error: {e}") + raise EngineHTTPException( + status_code=500, + detail=f"Add scores failed.", + ) except Exception as e: logger.error(f"Score update failed with error: {e}") raise EngineHTTPException(status_code=500, detail="Score update failed.")