refactor: use for in

Author: tonyfettes

array/deprecated.mbt

@@ -46,7 +46,7 @@ pub fn FixedArray::new[T](length : Int, value : () -> T) -> FixedArray[T] {
     []
   } else {
     let array = FixedArray::make(length, value())
-    for i = 1; i < length; i = i + 1 {
+    for i in 1..<length {
       array[i] = value()
     }
     array

array/fixedarray.mbt

@@ -244,7 +244,7 @@ pub fn FixedArray::map[T, U](
     return []
   }
   let res = FixedArray::make(self.length(), f(self[0]))
-  for i = 1; i < self.length(); i = i + 1 {
+  for i in 1..<self.length() {
     res[i] = f(self[i])
   }
   res
@@ -279,7 +279,7 @@ pub fn FixedArray::mapi[T, U](
     return []
   }
   let res = FixedArray::make(self.length(), f(0, self[0]))
-  for i = 1; i < self.length(); i = i + 1 {
+  for i in 1..<self.length() {
     res[i] = f(i, self[i])
   }
   res
@@ -338,7 +338,7 @@ pub fn FixedArray::makei[T](length : Int, value : (Int) -> T) -> FixedArray[T] {
     []
   } else {
     let array = FixedArray::make(length, value(0))
-    for i = 1; i < length; i = i + 1 {
+    for i in 1..<length {
       array[i] = value(i)
     }
     array
@@ -544,7 +544,7 @@ test "rev_foldi" {
 /// ```
 pub fn FixedArray::rev_inplace[T](self : FixedArray[T]) -> Unit {
   let mid_len = self.length() / 2
-  for i = 0; i < mid_len; i = i + 1 {
+  for i in 0..<mid_len {
     let j = self.length() - i - 1
     let temp = self[i]
     self[i] = self[j]
@@ -578,7 +578,7 @@ pub fn FixedArray::rev[T](self : FixedArray[T]) -> FixedArray[T] {
     [.., first] => {
       let res = FixedArray::make(self.length(), first)
       let len = self.length()
-      for i = 1; i < len; i = i + 1 {
+      for i in 1..<len {
         res[i] = self[len - 1 - i]
       }
       res
@@ -683,7 +683,7 @@ test "swap" {
 /// assert_false!(arr.all(fn(ele) { ele < 5 }))
 /// ```
 pub fn FixedArray::all[T](self : FixedArray[T], f : (T) -> Bool) -> Bool {
-  for i = 0; i < self.length(); i = i + 1 {
+  for i in 0..<self.length() {
     if not(f(self[i])) {
       return false
     }
@@ -719,7 +719,7 @@ test "all" {
 /// assert_true!(arr.any(fn(ele) { ele < 5 }))
 /// ```
 pub fn FixedArray::any[T](self : FixedArray[T], f : (T) -> Bool) -> Bool {
-  for i = 0; i < self.length(); i = i + 1 {
+  for i in 0..<self.length() {
     if f(self[i]) {
       return true
     }
@@ -770,7 +770,7 @@ test "fill" {
 /// assert_eq!(arr.search(3), Some(0))
 /// ```
 pub fn FixedArray::search[T : Eq](self : FixedArray[T], value : T) -> Int? {
-  for i = 0; i < self.length(); i = i + 1 {
+  for i in 0..<self.length() {
     if self[i] == value {
       return Some(i)
     }
@@ -806,7 +806,7 @@ test "search" {
 /// assert_true!(arr.contains(3))
 /// ```
 pub fn FixedArray::contains[T : Eq](self : FixedArray[T], value : T) -> Bool {
-  for i = 0; i < self.length(); i = i + 1 {
+  for i in 0..<self.length() {
     if self[i] == value {
       return true
     }
@@ -848,7 +848,7 @@ pub fn FixedArray::starts_with[T : Eq](
   if prefix.length() > self.length() {
     return false
   }
-  for i = 0; i < prefix.length(); i = i + 1 {
+  for i in 0..<prefix.length() {
     if self[i] != prefix[i] {
       return false
     }
@@ -898,7 +898,7 @@ pub fn FixedArray::ends_with[T : Eq](
   if suf_len > self_len {
     return false
   }
-  for i = 0; i < suf_len; i = i + 1 {
+  for i in 0..<suf_len {
     if self[self_len - suf_len + i] != suffix[i] {
       return false
     }
@@ -967,7 +967,7 @@ pub impl[T : Eq] Eq for FixedArray[T] with op_equal(
   if self.length() != that.length() {
     return false
   }
-  for i = 0; i < self.length(); i = i + 1 {
+  for i in 0..<self.length() {
     if self[i] != that[i] {
       return false
     }
@@ -1012,7 +1012,7 @@ fn deep_clone[T](arr : FixedArray[T]) -> FixedArray[T] {
     []
   } else {
     let result = FixedArray::make(len, arr[0])
-    for i = 0; i < len; i = i + 1 {
+    for i in 0..<len {
       result[i] = arr[i]
     }
     result
@@ -1073,10 +1073,10 @@ pub fn FixedArray::op_add[T](
     deep_clone(self)
   } else {
     let result = FixedArray::make(slen + nlen, self[0])
-    for i = 1; i < slen; i = i + 1 {
+    for i in 1..<slen {
       result[i] = self[i]
     }
-    for i = 0; i < nlen; i = i + 1 {
+    for i in 0..<nlen {
       result[i + slen] = other[i]
     }
     result

array/fixedarray_sort.mbt

@@ -306,7 +306,7 @@ fn fixed_get_limit(len : Int) -> Int {
 fn fixed_try_bubble_sort[T : Compare](arr : FixedArraySlice[T]) -> Bool {
   let max_tries = 8
   let mut tries = 0
-  for i = 1; i < arr.length(); i = i + 1 {
+  for i in 1..<arr.length() {
     let mut sorted = true
     for j = i; j > 0 && arr[j - 1] > arr[j]; j = j - 1 {
       sorted = false
@@ -329,7 +329,7 @@ fn fixed_try_bubble_sort[T : Compare](arr : FixedArraySlice[T]) -> Bool {
 /// 
 /// Returns whether the array is sorted.
 fn fixed_bubble_sort[T : Compare](arr : FixedArraySlice[T]) -> Unit {
-  for i = 1; i < arr.length(); i = i + 1 {
+  for i in 1..<arr.length() {
     for j = i; j > 0 && arr[j - 1] > arr[j]; j = j - 1 {
       arr.swap(j, j - 1)
     }
@@ -353,7 +353,7 @@ fn fixed_partition[T : Compare](
   let pivot = arr[arr.length() - 1]
   let mut i = 0
   let mut partitioned = true
-  for j = 0; j < arr.length() - 1; j = j + 1 {
+  for j in 0..<(arr.length() - 1) {
     if arr[j] < pivot {
       if i != j {
         arr.swap(i, j)
@@ -543,7 +543,7 @@ test "stable_sort_complex" {
   let arr = FixedArray::make(total_len, 0)
   let mut index = 0
   for i = 0, len = run_lens.length(); i < len; i = i + 1 {
-    for j = 0; j < run_lens[i]; j = j + 1 {
+    for j in 0..<run_lens[i] {
       arr[index] = j
       index += 1
     }

array/fixedarray_sort_by.mbt

@@ -200,7 +200,7 @@ fn fixed_try_bubble_sort_by[T](
 ) -> Bool {
   let max_tries = 8
   let mut tries = 0
-  for i = 1; i < arr.length(); i = i + 1 {
+  for i in 1..<arr.length() {
     let mut sorted = true
     for j = i; j > 0 && cmp(arr[j - 1], arr[j]) > 0; j = j - 1 {
       sorted = false
@@ -226,7 +226,7 @@ fn fixed_bubble_sort_by[T](
   arr : FixedArraySlice[T],
   cmp : (T, T) -> Int
 ) -> Unit {
-  for i = 1; i < arr.length(); i = i + 1 {
+  for i in 1..<arr.length() {
     for j = i; j > 0 && cmp(arr[j - 1], arr[j]) > 0; j = j - 1 {
       arr.swap(j, j - 1)
     }
@@ -256,7 +256,7 @@ fn fixed_partition_by[T](
   let pivot = arr[arr.length() - 1]
   let mut i = 0
   let mut partitioned = true
-  for j = 0; j < arr.length() - 1; j = j + 1 {
+  for j in 0..<(arr.length() - 1) {
     if cmp(arr[j], pivot) < 0 {
       if i != j {
         arr.swap(i, j)

array/sort.mbt

@@ -110,7 +110,7 @@ fn get_limit(len : Int) -> Int {
 fn try_bubble_sort[T : Compare](arr : ArrayView[T]) -> Bool {
   let max_tries = 8
   let mut tries = 0
-  for i = 1; i < arr.length(); i = i + 1 {
+  for i in 1..<arr.length() {
     let mut sorted = true
     for j = i; j > 0 && arr[j - 1] > arr[j]; j = j - 1 {
       sorted = false
@@ -129,7 +129,7 @@ fn try_bubble_sort[T : Compare](arr : ArrayView[T]) -> Bool {
 ///|
 /// Used when the array is small enough (<=16) to avoid recursion overhead.
 fn ArrayView::insertion_sort[T : Compare](arr : ArrayView[T]) -> Unit {
-  for i = 1; i < arr.length(); i = i + 1 {
+  for i in 1..<arr.length() {
     for j = i; j > 0 && arr[j - 1] > arr[j]; j = j - 1 {
       arr.swap(j, j - 1)
     }
@@ -142,7 +142,7 @@ fn partition[T : Compare](arr : ArrayView[T], pivot_index : Int) -> (Int, Bool)
   let pivot = arr[arr.length() - 1]
   let mut i = 0
   let mut partitioned = true
-  for j = 0; j < arr.length() - 1; j = j + 1 {
+  for j in 0..<(arr.length() - 1) {
     if arr[j] < pivot {
       if i != j {
         arr.swap(i, j)

array/sort_by.mbt

@@ -124,7 +124,7 @@ fn quick_sort_by[T](
 fn try_bubble_sort_by[T](arr : ArrayView[T], cmp : (T, T) -> Int) -> Bool {
   let max_tries = 8
   let mut tries = 0
-  for i = 1; i < arr.length(); i = i + 1 {
+  for i in 1..<arr.length() {
     let mut sorted = true
     for j = i; j > 0 && cmp(arr[j - 1], arr[j]) > 0; j = j - 1 {
       sorted = false
@@ -147,7 +147,7 @@ fn try_bubble_sort_by[T](arr : ArrayView[T], cmp : (T, T) -> Int) -> Bool {
 ///
 /// Returns whether the array is sorted.
 fn bubble_sort_by[T](arr : ArrayView[T], cmp : (T, T) -> Int) -> Unit {
-  for i = 1; i < arr.length(); i = i + 1 {
+  for i in 1..<arr.length() {
     for j = i; j > 0 && cmp(arr[j - 1], arr[j]) > 0; j = j - 1 {
       arr.swap(j, j - 1)
     }
@@ -164,7 +164,7 @@ fn partition_by[T](
   let pivot = arr[arr.length() - 1]
   let mut i = 0
   let mut partitioned = true
-  for j = 0; j < arr.length() - 1; j = j + 1 {
+  for j in 0..<(arr.length() - 1) {
     if cmp(arr[j], pivot) < 0 {
       if i != j {
         arr.swap(i, j)

array/view.mbt

@@ -44,7 +44,7 @@ pub typealias View[T] = ArrayView[T]
 /// ```
 pub fn View::rev_inplace[T](self : View[T]) -> Unit {
   let mid_len = self.length() / 2
-  for i = 0; i < mid_len; i = i + 1 {
+  for i in 0..<mid_len {
     let j = self.length() - i - 1
     self.swap(i, j)
   }

builtin/array.mbt

@@ -658,7 +658,7 @@ pub fn Array::is_sorted[T : Compare](self : Array[T]) -> Bool {
 /// }
 /// ```
 pub fn Array::rev_inplace[T](self : Array[T]) -> Unit {
-  for i = 0; i < self.length() / 2; i = i + 1 {
+  for i in 0..<(self.length() / 2) {
     let temp = self.unsafe_get(i)
     self.unsafe_set(i, self.unsafe_get(self.length() - i - 1))
     self.unsafe_set(self.length() - i - 1, temp)
@@ -686,7 +686,7 @@ pub fn Array::rev_inplace[T](self : Array[T]) -> Unit {
 /// ```
 pub fn Array::rev[T](self : Array[T]) -> Array[T] {
   let arr = Array::make_uninit(self.length())
-  for i = 0; i < self.length(); i = i + 1 {
+  for i in 0..<self.length() {
     arr.unsafe_set(i, self.unsafe_get(self.length() - i - 1))
   }
   arr
@@ -790,7 +790,7 @@ pub fn Array::starts_with[T : Eq](self : Array[T], prefix : Array[T]) -> Bool {
   if prefix.length() > self.length() {
     return false
   }
-  for i = 0; i < prefix.length(); i = i + 1 {
+  for i in 0..<prefix.length() {
     if self.unsafe_get(i) != prefix.unsafe_get(i) {
       break false
     }
@@ -829,7 +829,7 @@ pub fn Array::ends_with[T : Eq](self : Array[T], suffix : Array[T]) -> Bool {
   if suffix.length() > self.length() {
     return false
   }
-  for i = 0; i < suffix.length(); i = i + 1 {
+  for i in 0..<suffix.length() {
     if self.unsafe_get(self.length() - suffix.length() + i) !=
       suffix.unsafe_get(i) {
       break false
@@ -1278,7 +1278,7 @@ pub fn Array::flatten[T](self : Array[Array[T]]) -> Array[T] {
 /// ```
 pub fn Array::repeat[T](self : Array[T], times : Int) -> Array[T] {
   let v = Array::new(capacity=self.length() * times)
-  for i = 0; i < times; i = i + 1 {
+  for i in 0..<times {
     v.append(self)
   }
   v
@@ -1473,7 +1473,7 @@ pub fn Array::dedup[T : Eq](self : Array[T]) -> Unit {
     return
   }
   let mut w = 1
-  for i = 1; i < self.length(); i = i + 1 {
+  for i in 1..<self.length() {
     if self[i] != self[w - 1] {
       self[w] = self[i]
       w = w + 1
@@ -1509,13 +1509,13 @@ pub fn Array::dedup[T : Eq](self : Array[T]) -> Unit {
 pub fn Array::extract_if[T](self : Array[T], f : (T) -> Bool) -> Array[T] {
   let v = []
   let indices = []
-  for i = 0; i < self.length(); i = i + 1 {
+  for i in 0..<self.length() {
     if f(self[i]) {
       v.push(self[i])
       indices.push(i)
     }
   }
-  for i = 0; i < indices.length(); i = i + 1 {
+  for i in 0..<indices.length() {
     self.remove(indices[i] - i) |> ignore
   }
   v

builtin/autoloc.mbt

@@ -64,7 +64,7 @@ pub(all) type ArgsLoc Array[SourceLoc?] derive(Show)
 pub fn ArgsLoc::to_json(self : ArgsLoc) -> String {
   let buf = StringBuilder::new(size_hint=10)
   buf.write_char('[')
-  for i = 0; i < self._.length(); i = i + 1 {
+  for i in 0..<self._.length() {
     if i != 0 {
       buf.write_string(", ")
     }