Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement viem Client #131

Merged
merged 18 commits into from
Sep 11, 2023
Merged

Implement viem Client #131

merged 18 commits into from
Sep 11, 2023

Conversation

mmaurello
Copy link
Contributor

@mmaurello mmaurello commented Sep 5, 2023 •
edited
Loading

Description

Please explain the changes this PR addresses here.

Checklist

  • If this requires a documentation change, I have created a PR in moonbeam-docs repository.
  • If this requires it, I have updated the Readme
  • If necessary, I have updated the examples
  • I have verified if I need to create/update unit tests
  • I have verified if I need to create/update acceptance tests
  • If necessary, I have run acceptance tests on this branch in CI

@changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: a8d1696

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@moonbeam-network/xcm-config Minor
@moonbeam-network/xcm-sdk Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mmaurello mmaurello marked this pull request as ready for review September 5, 2023 15:29
ekenigs
ekenigs requested changes Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@ekenigs ekenigs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments.

packages/sdk/package.json Outdated Show resolved Hide resolved
packages/sdk/src/contract/contract.factory.ts Outdated Show resolved Hide resolved
packages/sdk/src/contract/contracts/Erc20/Erc20.ts Outdated Show resolved Hide resolved
packages/sdk/src/contract/contracts/Xtokens/Xtokens.ts Outdated Show resolved Hide resolved
packages/sdk/src/sdk.interfaces.ts Show resolved Hide resolved
@mmaurello mmaurello requested a review from ekenigs September 7, 2023 12:02
@mmaurello mmaurello merged commit 63d81d6 into main Sep 11, 2023
4 checks passed
@mmaurello mmaurello deleted the mjm/viem branch September 11, 2023 08:51
@github-actions github-actions bot mentioned this pull request Sep 11, 2023
Merged
@mmaurello mmaurello mentioned this pull request Sep 12, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekenigs ekenigs ekenigs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmaurello @ekenigs