Add Kusama and Kusama Asset Hub max xcm delivery fees (#198)

* add manually max Xcm Delivery fees for Kusama and Kusama Asset Hub * add changeset
moonbeam-foundation · Jan 29, 2024 · 7e356c4 · 7e356c4
1 parent ce63c3e
commit 7e356c4
Show file tree

Hide file tree

Showing 5 changed files with 37 additions and 2 deletions.
diff --git a/.changeset/eight-parrots-cheer.md b/.changeset/eight-parrots-cheer.md
@@ -0,0 +1,6 @@
+---
+'@moonbeam-network/xcm-config': patch
+'@moonbeam-network/xcm-sdk': patch
+---
+
+Xcm Delivery fees for Kusama and Kusama Asset Hub
diff --git a/packages/config/src/configs/kusama.ts b/packages/config/src/configs/kusama.ts
@@ -23,6 +23,11 @@ export const kusamaConfig = new ChainConfig({
         .xcmPallet()
         .limitedReserveTransferAssets(0)
         .here(),
+      fee: {
+        asset: ksm,
+        balance: BalanceBuilder().substrate().system().account(),
+        xcmDeliveryFeeAmount: 0.0015,
+      },
     }),
   ],
   chain: kusama,

diff --git a/packages/config/src/configs/kusamaAssetHub.ts b/packages/config/src/configs/kusamaAssetHub.ts
@@ -27,6 +27,7 @@ export const kusamaAssetHubConfig = new ChainConfig({
       fee: {
         asset: ksm,
         balance: BalanceBuilder().substrate().system().account(),
+        xcmDeliveryFeeAmount: 0.00115,
       },
       min: AssetMinBuilder().assets().asset(),
     }),
@@ -46,6 +47,7 @@ export const kusamaAssetHubConfig = new ChainConfig({
       fee: {
         asset: ksm,
         balance: BalanceBuilder().substrate().system().account(),
+        xcmDeliveryFeeAmount: 0.00115,
       },
       min: AssetMinBuilder().assets().asset(),
     }),

diff --git a/packages/config/src/types/AssetConfig.ts b/packages/config/src/types/AssetConfig.ts
@@ -25,6 +25,7 @@ export interface DestinationFeeConfig extends FeeAssetConfig {
 export interface FeeAssetConfig {
   asset: Asset;
   balance: BalanceConfigBuilder;
+  xcmDeliveryFeeAmount?: number;
 }
 
 export class AssetConfig {

diff --git a/packages/sdk/src/getTransferData/getSourceData.ts b/packages/sdk/src/getTransferData/getSourceData.ts
@@ -6,7 +6,7 @@ import {
 } from '@moonbeam-network/xcm-builder';
 import { FeeAssetConfig, TransferConfig } from '@moonbeam-network/xcm-config';
 import { AssetAmount } from '@moonbeam-network/xcm-types';
-import { convertDecimals } from '@moonbeam-network/xcm-utils';
+import { convertDecimals, toBigInt } from '@moonbeam-network/xcm-utils';
 import Big from 'big.js';
 import { TransferContractInterface, createContract } from '../contract';
 import { PolkadotService } from '../polkadot';
@@ -121,6 +121,7 @@ export async function getSourceData({
     decimals: zeroFeeAmount.decimals,
     evmSigner,
     extrinsic,
+    feeConfig: config.fee,
     polkadot,
     sourceAddress,
   });
@@ -181,6 +182,7 @@ export interface GetFeeParams {
   decimals: number;
   evmSigner?: EvmSigner;
   extrinsic?: ExtrinsicConfig;
+  feeConfig?: FeeAssetConfig;
   polkadot: PolkadotService;
   sourceAddress: string;
 }
@@ -191,6 +193,7 @@ export async function getFee({
   decimals,
   evmSigner,
   extrinsic,
+  feeConfig,
   polkadot,
   sourceAddress,
 }: GetFeeParams): Promise<bigint> {
@@ -203,7 +206,16 @@ export async function getFee({
   }
 
   if (extrinsic) {
-    return getExtrinsicFee(balance, extrinsic, polkadot, sourceAddress);
+    const extrinsicFee = await getExtrinsicFee(
+      balance,
+      extrinsic,
+      polkadot,
+      sourceAddress,
+    );
+
+    const xcmDeliveryFee = getXcmDeliveryFee(decimals, feeConfig);
+
+    return extrinsicFee + xcmDeliveryFee;
   }
 
   throw new Error('Either contract or extrinsic must be provided');
@@ -246,6 +258,15 @@ export async function getExtrinsicFee(
   }
 }
 
+function getXcmDeliveryFee(
+  decimals: number,
+  feeConfig?: FeeAssetConfig,
+): bigint {
+  return feeConfig?.xcmDeliveryFeeAmount
+    ? toBigInt(feeConfig.xcmDeliveryFeeAmount, decimals)
+    : 0n;
+}
+
 export interface GetMaxParams {
   balanceAmount: AssetAmount;
   existentialDeposit: AssetAmount;