Hack 500ms deadline as an experiment #726
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It won't build because of crossed crowdloan rewards dependencies. curses. This can be fixed after moonbeam-foundation/crowdloan-rewards#26 lands which can be fixed after we update our substrate dependency. |
|
This is the real underlying fix for this problem paritytech/substrate#9611. So the hack is no longer necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes our nimbus dependency to one that is hacked to have a 1s deadline rather than the typical 500ms deadline.
This is based on #722 just because of the order of nimbus commits. If we decide we actually want to merge this then we either need #722 first, or I can create a new nimbus branch. But I don't imagine we'll be merging this soon.