Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors trying to integrate into another parachain #52

Open
ltfschoen opened this issue Mar 13, 2022 · 4 comments
Open

Errors trying to integrate into another parachain #52

ltfschoen opened this issue Mar 13, 2022 · 4 comments

Comments

@ltfschoen
Copy link

I get the errors shown in the description of this PR when trying to incorporate this pallet into another parachain DataHighway-DHX/DataHighway-Parachain#18

@crystalin
Copy link
Contributor

It seems to be missing some particular trait but I'm not sure which one.
@girazoki can have a look at it this week

@girazoki
Copy link
Contributor

Hi @ltfschoen, how can I replicate your error? What kind of build are u making to get these errors?

@ltfschoen
Copy link
Author

ltfschoen commented Mar 15, 2022

@girazoki i'm just running the following. the repository is based on the substrate-parachain-template

git clone https://github.com/DataHighway-DHX/DataHighway-Parachain
git fetch origin luke/migrate-standalone-pr-215-step-by-step-crowdloan-rewards:luke/migrate-standalone-pr-215-step-by-step-crowdloan-rewards
git checkout luke/migrate-standalone-pr-215-step-by-step-crowdloan-rewards
./scripts/init.sh
cargo build --release

@girazoki
Copy link
Contributor

Hi @ltfschoen, the main reason for the failure I think is that we have our own forks of substrate/cumulus and it conflicts with yours. I created a branch in this repo called polkadot-v0.9.17, that you can use for your project, that points at the parity versions of substrate/cumulus.

I tried compiling your runtime with this new branch and it works. Feel free to use it, and also remind us to create appropriate branches as we continue upgrading this pallet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants