Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update monitors on refresh #182

Open
unkrich opened this issue Apr 13, 2022 · 0 comments
Open

Update monitors on refresh #182

unkrich opened this issue Apr 13, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@unkrich
Copy link
Collaborator

unkrich commented Apr 13, 2022

Problem

Monitors are created on the initial run via a SchemaCollectorJob https://github.com/monosidev/monosi/blob/master/src/server/handlers/datasources.py#L55

After this, if new tables, columns, or other entities are introduced, we do not automatically monitor them and we should consider doing so.

Solution

The simplest solution may be to keep this job running and not remove it as in line https://github.com/monosidev/monosi/blob/master/src/server/handlers/datasources.py#L69

This is a shortsighted but temporary possible solution is to simply delete this line (mostly made possible due to db constraints to make sure duplicate monitors aren't created).

@unkrich unkrich added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant