Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add email as an Integration #181

Open
unkrich opened this issue Apr 13, 2022 · 3 comments
Open

Add email as an Integration #181

unkrich opened this issue Apr 13, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@unkrich
Copy link
Collaborator

unkrich commented Apr 13, 2022

Description

Currently we support alerts via webhook and slack (webhooks). Both are relatively early, but we are looking to support email notifications as well.

Expected behavior

Expected behavior is to be able to create an email alert notification.

This would require adding an integration option on the frontend: https://github.com/monosidev/monosi/blob/master/src/ui/src/components/forms/IntegrationForm/index.tsx

As well as an integration implementation on the backend
https://github.com/monosidev/monosi/tree/master/src/server/integrations

We should consider better subclassing and defining the alert that is going out to each of these integrations as well.

Additional context

Implementation likely uses https://docs.python.org/3/library/smtplib.html to send email and exposes configuration variables to define the SMTP server/auth information

@unkrich unkrich added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed and removed good first issue Good for newcomers labels Apr 13, 2022
@yongyx
Copy link

yongyx commented Apr 14, 2022

I would like to contribute to this issue.

@iporollo
Copy link
Contributor

Thanks for offering to help here @yongyx , let us know if you have any questions!

@unkrich
Copy link
Collaborator Author

unkrich commented Apr 14, 2022

Also, our integration code is a bit of a mess today, so if you find this to be a bit more challenging than expected, this is probably because we should consider refactoring the base implementation.

Let me know if that's the case!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants