Reuse the same tag separator array

Therzok · Therzok · commit 25cb1aa3cd01 · 2023-02-21T01:01:06.000+02:00
We're targeting netstandard2.0 and don't have ReadOnlySpan or any of the new APIs that avoid allocating
diff --git a/Xwt/Xwt.Drawing/Image.cs b/Xwt/Xwt.Drawing/Image.cs
@@ -973,6 +973,7 @@ class ImageTagSet
 		string[] tagsArray;
 
 		public static readonly ImageTagSet Empty = new ImageTagSet (new string[0]);
+		static readonly char[] tagSeparators = { '~' };
 
 		public ImageTagSet (string [] tagsArray)
 		{
@@ -988,7 +989,7 @@ public bool IsEmpty {
 
 		public ImageTagSet (string tags)
 		{
-			tagsArray = tags.Split (new [] { '~' }, StringSplitOptions.RemoveEmptyEntries);
+			tagsArray = tags.Split (tagSeparators, StringSplitOptions.RemoveEmptyEntries);
 			Array.Sort (AsArray);
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -973,6 +973,7 @@ class ImageTagSet`
`973`	`973`	`string[] tagsArray;`
`974`	`974`
`975`	`975`	`public static readonly ImageTagSet Empty = new ImageTagSet (new string[0]);`
	`976`	`+ static readonly char[] tagSeparators = { '~' };`
`976`	`977`
`977`	`978`	`public ImageTagSet (string [] tagsArray)`
`978`	`979`	`{`
`@@ -988,7 +989,7 @@ public bool IsEmpty {`
`988`	`989`
`989`	`990`	`public ImageTagSet (string tags)`
`990`	`991`	`{`
`991`		`- tagsArray = tags.Split (new [] { '~' }, StringSplitOptions.RemoveEmptyEntries);`
	`992`	`+ tagsArray = tags.Split (tagSeparators, StringSplitOptions.RemoveEmptyEntries);`
`992`	`993`	`Array.Sort (AsArray);`
`993`	`994`	`}`
`994`	`995`