Skip to content
This repository has been archived by the owner on Sep 4, 2024. It is now read-only.

Unknown extension node attributes are ignored #116

Open
mhutch opened this issue May 15, 2018 · 0 comments
Open

Unknown extension node attributes are ignored #116

mhutch opened this issue May 15, 2018 · 0 comments

Comments

@mhutch
Copy link
Member

mhutch commented May 15, 2018

Unknown extension node attributes are ignored. It's easy to typo an attribute and not notice it, and this can be very painful to debug for a consumer.

Even if custom nodes read attributes programmatically, they should still declare them on the class for docs and basic validation. We should warn on undeclared attributes regardless, and MA consumers can go fix up their custom nodes.

KirillOsenkov added a commit to mono/monodevelop that referenced this issue May 15, 2018
It was being loaded for all mime types. Now the mimeTypes will be respected.

Bug mono/mono-addins#116 is a suggestion to add a warning to prevent such errors in the future.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant