Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Words filter presets does not account for different spellings when using English 1k+ #6097

Open
2 tasks done
IvanVZabrodin opened this issue Dec 6, 2024 · 1 comment
Open
2 tasks done
Labels
bug Something isn't working

Comments

@IvanVZabrodin
Copy link

Did you clear cache before opening an issue?

  • I have cleared my cache

Is there an existing issue for this?

  • I have searched the existing issues

Does the issue happen when logged in?

Yes

Does the issue happen when logged out?

Yes

Does the issue happen in incognito mode when logged in?

Yes

Does the issue happen in incognito mode when logged out?

Yes

Account name

Yes_Brain

Account config

No response

Current Behavior

When choosing a preset such as the homerow preset for colemak in the word filter mode using English 1K in custom, certain words that have different spellings in English (such as tire) change spelling (from tire to tyre), no longer using only the letters in the home row.

Expected Behavior

Words that do follow the word filter should not be present.

Steps To Reproduce

  1. Go to custom mode
  2. Press change
  3. Go to words filter
  4. Choose English 1K, Home Row and Colemak
  5. Press generate and set
  6. Look for the word tire
  7. Click Ok
  8. Look and see that the word tire has been replaced with tyre

Environment

  • OS: Windows 11
  • Browser: Google Chrome
  • Browser Version: Version 131.0.6778.86 (Official Build) (64-bit)

Anything else?

image
image

@IvanVZabrodin IvanVZabrodin added the bug Something isn't working label Dec 6, 2024
@Miodec
Copy link
Member

Miodec commented Dec 9, 2024

This is because british english is applied when the tests are generated, not when they are filtered. I could apply the replacements when filtering, but I wonder if this might cause issues somewhere else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants