Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"japanese hiragana" keymap issues #5968

Open
2 tasks done
TBBle opened this issue Oct 17, 2024 · 1 comment
Open
2 tasks done

"japanese hiragana" keymap issues #5968

TBBle opened this issue Oct 17, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@TBBle
Copy link

TBBle commented Oct 17, 2024

Did you clear cache before opening an issue?

  • I have cleared my cache

Is there an existing issue for this?

  • I have searched the existing issues

Does the issue happen when logged in?

Yes

Does the issue happen when logged out?

Yes

Does the issue happen in incognito mode when logged in?

Yes

Does the issue happen in incognito mode when logged out?

Yes

Account name

TBBle

Account config

{"theme":"solarized_dark","themeLight":"serika","themeDark":"serika_dark","autoSwitchTheme":false,"customTheme":false,"customThemeColors":["#323437","#e2b714","#e2b714","#646669","#2c2e31","#d1d0c5","#ca4754","#7e2a33","#ca4754","#7e2a33"],"favThemes":["solarized_dark"],"showKeyTips":true,"smoothCaret":"medium","quickRestart":"enter","punctuation":false,"numbers":false,"words":50,"time":120,"mode":"time","quoteLength":[1],"language":"japanese_hiragana","fontSize":2,"freedomMode":false,"difficulty":"normal","blindMode":false,"quickEnd":false,"caretStyle":"default","paceCaretStyle":"default","flipTestColors":false,"layout":"default","funbox":"none","confidenceMode":"off","indicateTypos":"below","timerStyle":"mini","liveSpeedStyle":"off","liveAccStyle":"off","liveBurstStyle":"off","colorfulMode":false,"randomTheme":"off","timerColor":"main","timerOpacity":"1","stopOnError":"off","showAllLines":false,"keymapMode":"next","keymapStyle":"staggered","keymapLegendStyle":"dynamic","keymapLayout":"japanese_hiragana","keymapShowTopRow":"always","keymapSize":1,"fontFamily":"Fira_Code","smoothLineScroll":false,"alwaysShowDecimalPlaces":false,"alwaysShowWordsHistory":false,"singleListCommandLine":"on","capsLockWarning":true,"playSoundOnError":"4","playSoundOnClick":"1","soundVolume":0.5,"startGraphsAtZero":true,"showOutOfFocusWarning":true,"paceCaret":"off","paceCaretCustomSpeed":100,"repeatedPace":true,"accountChart":["on","on","on","on"],"minWpm":"off","minWpmCustomSpeed":100,"highlightMode":"letter","typingSpeedUnit":"wpm","ads":"result","hideExtraLetters":false,"strictSpace":false,"minAcc":"off","minAccCustom":90,"monkey":false,"repeatQuotes":"off","oppositeShiftMode":"off","customBackground":"","customBackgroundSize":"cover","customBackgroundFilter":[0,1,1,1],"customLayoutfluid":"qwerty#dvorak#colemak","monkeyPowerLevel":"off","minBurst":"off","minBurstCustomSpeed":100,"burstHeatmap":false,"britishEnglish":false,"lazyMode":false,"showAverage":"off","tapeMode":"off","maxLineWidth":0}

Current Behavior

Some issues with the Japanese keymap display for kana-input usage:

  • This layout is a 104-key layout, but the shown layout is missing the left-most key on the top row, ろ and the right-most key on the second-from-top row む.
  • (Based on the keymap data, I don't have a 104-key keyboard to test with): The shifted value of the ほ key should be ー, i.e., the long vowel marker in, e.g., ラーメン "ramen", but currently appears to be ほ.
  • "Next key" mode does not show the next key if the next character has a marker.
  • "Next key" mode, when expecting marker input (゛or ゜), shows the next character as the expected key instead.
  • In the "japanese katakana" language mode, no keys highlight at all.

As an example of the "next" key issues, if the next word to type is すずめ:

  • Initially, the す key is highlighted.
  • Typing す, now no key is highlighted.
  • Typing す again, now the め key is highlighted.
  • Typing ゛, め remains highlighted, and the ず is now bold (correct).

Expected Behavior

In the keymap

  • The ろ key, and the む key are present.
  • When holding Shift, ほ keys is replaced with ー.
  • When the next expected character has a marker, the "next" key press shown on the keyboard should be the unmarked character.
  • When the next expected keypress is a marker (゛or ゜), that key is highlighted.
  • In the "japanese katakana" language mode, the hiragana keycaps highlight for their katakana equivalents.

In example of the "next" key issues, if the next word to type is すずめ:

  • Initially, the す key is highlighted.
  • Typing す, the す key is still highlighted.
  • Typing す again, now the ゛ key is highlighted.
  • Typing ゛, め remains highlighted, and the ず is no longer underlined.

Steps To Reproduce

  1. Enable Kana input and select Hiragana mode in the Microsoft IME
  2. Load the supplied config. Specifically, enables "next" mode keymap with the "japanese hiragana" keymap layout and dynamic legend.
  3. Note the absence of the ろ key in the top row, it should appear to the left of ぬ (`~ key in US English)
  4. Note the absence of the ー key in the bottom row, it should appear to the right of へ (\| key in US English)
  5. Start a "japanese hiragana" test
  6. Note that no key highlight is shown when the next character to type has a marker.
  7. Note that when the next key input is expected to be a marker, the next character's key is highlighted instead.

Environment

  • OS: Windows 11
  • Browser: Google Chrome
  • Browser Version: Version 130.0.6723.58 (Official Build) (64-bit

Anything else?

This keyboard layout is actually an ANSI 104-key emulation of a full OADG 109-key keyboard, which has a slightly different layout for some of the keys. It'd be nice to add another keyboard layout that matches the full OADG109A layout, but that's actually a separate issue (feature request/future simple PR) but which might expose more layout issues as it needs another key in the bottom row.

Also, I had a quick look, and it looks like the missing ろ and む keycaps are in the layout data file, so that part must be a limitation elsewhere.

@TBBle TBBle added the bug Something isn't working label Oct 17, 2024
@TBBle
Copy link
Author

TBBle commented Oct 17, 2024

Keys in the data file but not shown on the keymap appears to be a generic problem: On examination, even the "qwerty" layout suffers from this, not showing the ` or \ keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant