Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Korean Language) Incorrect Underlining of Last Input Step in Monkeytype Input History #5492

Open
2 tasks done
qappell opened this issue Jun 15, 2024 · 1 comment
Open
2 tasks done
Assignees
Labels
bug Something isn't working

Comments

@qappell
Copy link

qappell commented Jun 15, 2024

Did you clear cache before opening an issue?

  • I have cleared my cache

Is there an existing issue for this?

  • I have searched the existing issues

Does the issue happen when logged in?

Yes

Does the issue happen when logged out?

Yes

Does the issue happen in incognito mode when logged in?

Yes

Does the issue happen in incognito mode when logged out?

Yes

Account name

Enthymeme

Account config

No response

Current Behavior

When completing a typing test in Korean when the final word in the test terminates in two character blocks (like "피로") where the last keystroke both alters the last block and creates a new block, the input history inaccurately underlines the last word as it was typed before the last keystroke. This misbehavior is isolated to the input history display; it is not counted as an error in the overall score and the quick end feature works correctly (this bug is not severe). Knowing how Hangul (the Korean script) is typed will make this unique issue clearer, so please see examples in the "Steps to Reproduce" section.

Expected Behavior

The input history should accurately reflect the final word's composition without incorrect underlining (given that the word is typed correctly).

Steps To Reproduce

  1. Install the Korean keyboard layout. You don't need to practice it, just pull up an image of what each key is.

  2. Open Monkeytype.com and click on the custom test type.

  3. Click "change" to edit the test and type any of the following affected example words as the last word of the test:

    하다

    • Keypresses: ㅎ, ㅏ, ㄷ, ㅏ
    • Character sequence (what is typed out with each keypress): ㅎ → 하 → 핟 → 하다

    묘비

    • Keypresses: ㅁ, ㅛ, ㅂ, ㅣ
    • Character sequence: ㅁ → 묘 → 묩 → 묘비

    천천히

    • Keypresses: ㅊ, ㅓ, ㄴ, ㅊ, ㅓ, ㄴ, ㅎ, ㅣ
    • Character sequence: 천천 → 천첞 → 천천히
  4. Complete the custom test by pressing the same keys as inputted.

  5. Observe the input history. The last word should be underlined as incorrect (as any wrong keystroke would be). Hover over it, and what Monkeytype thinks was typed is displayed (it will be what was typed just before the last keypress): 핟, 묩, and 천첞 respectively.

Environment

- OS: Windows 11
- Browser: Discovered on Vivaldi, occurs on Google Chrome
- Browser Version: Google Chrome: 126.0.6478.61 (Official Build) (64-bit) | Vivaldi: 6.7.3329.41 (Stable channel) (64-bit)
- Monkeytype version: v24.24.0

Anything else?

Helpful info: Wikipedia - Korean language and computers
Real example of unintended behavior:
Screenshot 2024-06-15 104540
Last word hovered on:
Screenshot 2024-06-15 104510

@qappell qappell added the bug Something isn't working label Jun 15, 2024
@shubhamvrs
Copy link

assign me this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants